Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename @sveltejs/kit/http to @sveltejs/kit/node #1391

Merged
merged 3 commits into from
May 10, 2021
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented May 9, 2021

see #1271 (comment). This feels more appropriate — the http was always supposed to refer specifically to https://nodejs.org/api/http.html, but calling it node is more self-explanatory, and gives us a place to put other Node-specific helpers in future

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 9b448a6 into master May 10, 2021
@Rich-Harris Rich-Harris deleted the node-helpers branch May 10, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants