Skip to content

chore: fix types for universal and server fields #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

benmccann
Copy link
Member

In #13535 I corrected the IDs to be optional, but I missed that the nodes themselves also weren't marked as optional. In dev.js and build_server.js they aren't necessarily filled out and everywhere they are accessed they are first checked

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 744093a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann force-pushed the universal-server-types branch from 6548355 to 744093a Compare March 5, 2025 05:29
@benmccann benmccann merged commit 3fdb664 into main Mar 5, 2025
15 checks passed
@benmccann benmccann deleted the universal-server-types branch March 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants