-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bundleStrategy
option
#13173
Conversation
🦋 Changeset detectedLatest commit: c067207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13173-svelte.vercel.app/ this is an automated message |
codeSplitJs
optioncodeSplit
option
Going to change this to |
If you want I can do it myself |
it's all good, I'm in the branch — I'm laying the groundwork for a separate feature that will be built on top of this, so there might be additional tweaks required |
codeSplit
optionbundleStrategy
option
This adapts the code from @benmccann branch https://github.com/sveltejs/kit/tree/iife to the new shape of the repo. I also had to make some other changes namely:
iife
output (which doesn't export anything and put everything in a global variable) i usedmanualChunks
with a single chunkapp
byexport * as app
kit.app
as a fallback forapp
I'm not super-familiar with the test suite so if you can suggest how and were i can test this (i guess it should be a new app?) i would appreciate (also not really sure if this has any repercussions).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits