Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: replace version in generateBundle (#12700)" #12779

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

dummdidumm
Copy link
Member

This reverts commit 3591411.

#12700 did introduce a bug where the file name stays the same, but the contents of a file can change because of a changed version. Revert for now and take another look at tackling this later.

Fixes #12771
Reopens #12260

This reverts commit 3591411.

#12700 did introduce a bug where the file name stays the same, but the contents of a file can change because of a changed version. Revert for now and take another look at tackling this later.

Fixes #12771
Reopens #12260
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 2ffcc41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: c83d626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino merged commit 13fb7f5 into main Oct 9, 2024
12 of 13 checks passed
@eltigerchino eltigerchino deleted the revert-stable-env-reference branch October 9, 2024 09:27
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
@dummdidumm
Copy link
Member Author

FYI @gtm-nayan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught error on startup: Cannot read env of undefined
2 participants