-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: detect build-emitted assets in prerenderer fetch #12201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5dfed36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Jul 24, 2024
ac3db20 to
6a8cd0e
Compare
Rich-Harris
reviewed
Aug 12, 2025
Rich-Harris
approved these changes
Aug 12, 2025
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very late, but thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #12200.
Assets emitted from a vite-plugin cannot be loaded by the pre-renderer's fetch implementation because they are not listed in the server manifest. This PR detects files the server's asset location (
server/_app/immutable/assets) and add them the manifest's asset list:https://github.com/JelmerBot/kit/blob/0fd65d309f029b36de41e28a3e8946d893e9385f/packages/kit/src/core/generate_manifest/index.js#L83C2-L90C3
The pre-renderer's
readis updated to detect these asset links:https://github.com/JelmerBot/kit/blob/0fd65d309f029b36de41e28a3e8946d893e9385f/packages/kit/src/core/postbuild/prerender.js#L214C5-L217C6
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits