Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vitest 1.0 #11196

Merged
merged 4 commits into from
Dec 8, 2023
Merged

feat: vitest 1.0 #11196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9a8147
feat: vitest 1.0
benmccann Dec 4, 2023
6ed90f2
merge version-2
benmccann Dec 5, 2023
db82e38
merge version-2
benmccann Dec 5, 2023
7697324
add create-svelte to major node update changeset
benmccann Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-pumas-pump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-svelte': minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a major because vitest also requires node18 ? ultimately we are going to do more changes to the templates in create-svelte that cause a major so not sure it matters much apart from where in the changelog its listed

Copy link
Member Author

@benmccann benmccann Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question. We have lots of things causing a major elsewhere but nothing on create-svelte yet. If we want to do a major this wouldn't be a bad PR to do it in. I don't know if we're worried about that causing issues on StackBlitz, etc. or anywhere like that

I could also edit the changeset where we dropped Node 16 support to include this package

---

feat: update vitest to 1.0
1 change: 1 addition & 0 deletions .changeset/thick-suits-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
'@sveltejs/kit': major
'create-svelte': major
---

breaking: require Node 18.13 or newer
2 changes: 1 addition & 1 deletion packages/adapter-netlify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@types/set-cookie-parser": "^2.4.2",
"rollup": "^4.2.0",
"typescript": "^5.3.2",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"peerDependencies": {
"@sveltejs/kit": "^1.5.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"polka": "^1.0.0-next.24",
"sirv": "^2.0.3",
"typescript": "^5.3.2",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"dependencies": {
"@rollup/plugin-commonjs": "^25.0.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter-vercel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"@types/node": "^18.19.1",
"typescript": "^5.3.2",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"peerDependencies": {
"@sveltejs/kit": "^1.5.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"sucrase": "^3.29.0",
"svelte": "^4.2.7",
"tiny-glob": "^0.2.9",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"scripts": {
"build": "node scripts/build-templates",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-svelte/shared/+vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"devDependencies": {
"vitest": "^0.34.0"
"vitest": "^1.0.0"
},
"scripts": {
"test": "vitest"
Expand Down
2 changes: 1 addition & 1 deletion packages/enhanced-img/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@
"svelte": "^4.2.7",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vitest": "^0.34.0"
"vitest": "^1.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"svelte-preprocess": "^5.1.1",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"peerDependencies": {
"@sveltejs/vite-plugin-svelte": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/test/build-errors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
},
"type": "module",
"devDependencies": {
"vitest": "^0.34.5"
"vitest": "^1.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/kit/test/prerendering/basics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"svelte-check": "^3.4.4",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"type": "module"
}
2 changes: 1 addition & 1 deletion packages/kit/test/prerendering/options/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"svelte-check": "^3.4.4",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"type": "module"
}
2 changes: 1 addition & 1 deletion packages/kit/test/prerendering/paths-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"svelte-check": "^3.4.4",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"type": "module"
}
2 changes: 1 addition & 1 deletion packages/migrate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@types/prompts": "^2.4.1",
"@types/semver": "^7.5.0",
"prettier": "^3.1.0",
"vitest": "^0.34.5"
"vitest": "^1.0.0"
},
"scripts": {
"test": "vitest run",
Expand Down
Loading
Loading