Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] External images won't load because of CORB #8598

Closed
msonnberger opened this issue Jan 19, 2023 · 1 comment · Fixed by #8607
Closed

[docs] External images won't load because of CORB #8598

msonnberger opened this issue Jan 19, 2023 · 1 comment · Fixed by #8607
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@msonnberger
Copy link
Contributor

msonnberger commented Jan 19, 2023

Describe the bug

I noticed that on the Vercel adapter docs page, settings.png isn't displayed in the "Node version" section. Chrome shows a warning in the console that this is due to Cross-Origin Resource Blocking. This page explains that when an <img>'s src has x-content-type-options set to nosniff and a (wrong) content-type: text/html header (which both applies to that image), CORB will block the response

Reproduction

Logs

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://github.com/sveltejs/kit/blob/master/packages/adapter-vercel/settings.png with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 90.28 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.2.0 - ~/.n/bin/node
    Yarn: 1.22.19 - ~/Library/pnpm/yarn
    npm: 8.19.3 - ~/.n/bin/npm
  Browsers:
    Firefox Developer Edition: 110.0
    Safari: 16.2

Severity

annoyance

Additional Information

Can reproduce in Arc (Chromium), Firefox and Safari

@msonnberger msonnberger changed the title [docs] External images won't load because of [CORB](https://chromium.googlesource.com/chromium/src/+/master/services/network/cross_origin_read_blocking_explainer.md)) [docs] External images won't load because of [CORB](https://chromium.googlesource.com/chromium/src/+/master/services/network/cross_origin_read_blocking_explainer.md) Jan 19, 2023
@msonnberger msonnberger changed the title [docs] External images won't load because of [CORB](https://chromium.googlesource.com/chromium/src/+/master/services/network/cross_origin_read_blocking_explainer.md) [docs] External images won't load because of CORB Jan 19, 2023
@dominikg dominikg added bug Something isn't working documentation Improvements or additions to documentation labels Jan 19, 2023
@dominikg
Copy link
Member

Introduced by #8531

Maybe colocate assets needed for docs to avoid this. Some links are also absolute (they had to be when it was in the adapters readme) that can now be relative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants