sveltekit:shutdown callback not being called

[bnahas]

Describe the bug

I am trying to use the "sveltekit:shutdown" event to close some resources but it doesn't appear that the callback is being invoked when the server is sent SIGINT. The server just stops with the callback never running.

Reproduction

Simple reproduction:

Sveltekit Shutdown

Logs

VITE v6.1.0  ready in 693 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
launching server
registering shutdown hook
initialization complete
user@computer: ~/sveltekitshutdown$

System Info

System:
    OS: Linux 5.15 Linux Mint 21.1 (Vera)
    CPU: (6) x64 Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz
    Memory: 3.43 GB / 15.56 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 9.15.4 - ~/.local/share/pnpm/pnpm
  npmPackages:
    svelte: ^5.0.0 => 5.19.10

Severity

annoyance

Additional Information

No response

[elliott-with-the-longest-name-on-github]

elliottjohnson@MacBookPro sveltekitshutdown % node build
launching server
registering shutdown hook
initialization complete
Listening on http://0.0.0.0:3000
^CSvelteKit has shutdown because of SIGINT
elliottjohnson@MacBookPro sveltekitshutdown % node build
launching server
registering shutdown hook
initialization complete
Listening on http://0.0.0.0:3000
^CSvelteKit has shutdown because of SIGINT
elliottjohnson@MacBookPro sveltekitshutdown % node build
launching server
registering shutdown hook
initialization complete
Listening on http://0.0.0.0:3000
^CSvelteKit has shutdown because of SIGINT
elliottjohnson@MacBookPro sveltekitshutdown % node build
launching server
registering shutdown hook
initialization complete
Listening on http://0.0.0.0:3000
^CSvelteKit has shutdown because of SIGINT
elliottjohnson@MacBookPro sveltekitshutdown % node build
launching server
registering shutdown hook
initialization complete
Listening on http://0.0.0.0:3000
^CSvelteKit has shutdown because of SIGINT

The repro doesn't have any instructions, but... it's worked exactly how it should every time I've tried it?

[bnahas]

Thanks for the prompt response, Elliot! Apologies for the lack of instructions in the repro but glad you figured it out. Your response helped me identify the discrepancy.

I was using the vite dev server to run it, assuming the dev server would reproduce the "sveltekit:shutdown" event if I was using the node adapter, but it appears that is not the case. I am new to sveltekit and did not realize the adapter is (completely?) irrelevant to the dev server.

I had reviewed #6841 prior to submitting this, but had I read up further in the thread I would have picked up on this. Rich Harris referenced vitejs/vite#7887 in #6841 as a limiting factor (if I understand correctly) for the dev server. That has since been closed in vite so maybe reproducing this is now possible. I'm not at the point where I feel I could take a stab at implementing that but maybe in the future.

Anyway, thanks for your assistance!

[dummdidumm]

Marking this as both feature request and documentation, depending on if we come up with a generic way for adapters to influence these situations, or if we should just document this caveat instead.

I suspect it would be possible with integrating Vite environment API, but until then it's probably too hard to pull off.