Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make %sveltekit.assets% placeholder available to src/error.html page #12712

Open
vijay8i opened this issue Sep 24, 2024 · 0 comments
Open

Make %sveltekit.assets% placeholder available to src/error.html page #12712

vijay8i opened this issue Sep 24, 2024 · 0 comments

Comments

@vijay8i
Copy link

vijay8i commented Sep 24, 2024

Describe the problem

It is not uncommon to share global style sheets for various pages of a site. SvelteKit provides %sveltekit.assets% placeholder to src/app.html but not to src/error.html. IMHO error pages should also share the same theme as the rest of the application/site, and so it comes as a surprise to discover that I cannot access the global stylesheets using %sveltekit.assets%. I am failing to see the reason as to why it is not made available in this context.

Describe the proposed solution

I would like to see %sveltekit.assets% made available to src/error.html page as well.

My first thought was to figure out where these placeholders are replaced and fix it. But thought I should ask if there is a reason for the omision.

The fix I have feels out of place but it is to simply use the src relative absolute path. Which implies that if I change the location of my assets folder, then I have to remember to go fix my error.html page, which is not ideal.

Alternatives considered

Get into the codebase and fix it!

Importance

would make my life easier

Additional Information

No response

@vijay8i vijay8i changed the title Make %sveltekit.assets% placeholder available to src/error.html` page Make %sveltekit.assets% placeholder available to src/error.html page Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant