Skip to content

Commit fb24644

Browse files
authored
fix: only show prerendering message when actually prerendering (#8809)
Also add "Building app" and "Analysing routes" log. Hopefully clears up some confusion around what happens at build time.
1 parent 5571e4a commit fb24644

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

.changeset/bright-moles-worry.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/kit': patch
3+
---
4+
5+
fix: only show prerendering message when actually prerendering

packages/kit/src/core/postbuild/prerender.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,15 @@ async function prerender({ out, manifest_path, metadata, verbose, env }) {
361361
saved.set(file, dest);
362362
}
363363

364+
if (
365+
config.prerender.entries.length > 1 ||
366+
config.prerender.entries[0] !== '*' ||
367+
prerender_map.size > 0
368+
) {
369+
// Only log if we're actually going to do something to not confuse users
370+
log.info('Prerendering');
371+
}
372+
364373
for (const entry of config.prerender.entries) {
365374
if (entry === '*') {
366375
for (const [id, prerender] of prerender_map) {

packages/kit/src/exports/vite/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,13 +596,17 @@ function kit({ svelte_config }) {
596596
);
597597

598598
// first, build server nodes without the client manifest so we can analyse it
599+
log.info('Analysing routes');
600+
599601
build_server_nodes(out, kit, manifest_data, server_manifest, null, null);
600602

601603
const metadata = await analyse({
602604
manifest_path,
603605
env: { ...env.private, ...env.public }
604606
});
605607

608+
log.info('Building app');
609+
606610
// create client build
607611
write_client_manifest(
608612
kit,
@@ -649,8 +653,6 @@ function kit({ svelte_config }) {
649653
build_server_nodes(out, kit, manifest_data, server_manifest, client_manifest, css);
650654

651655
// ...and prerender
652-
log.info('Prerendering');
653-
654656
const { prerendered, prerender_map } = await prerender({
655657
out,
656658
manifest_path,

0 commit comments

Comments
 (0)