better error handling

sveltejs · Sep 21, 2024 · 4e5253e · 4e5253e
1 parent e0cf4fa
commit 4e5253e
Showing 1 changed file with 30 additions and 4 deletions.
diff --git a/packages/migrate/utils.js b/packages/migrate/utils.js
@@ -312,8 +312,11 @@ export function update_svelte_file(file_path, transform_script_code, transform_s
 			}
 		);
 		fs.writeFileSync(file_path, transform_svelte_code(updated, file_path), 'utf-8');
-	} catch (e) {
-		console.error(`Error updating ${file_path}:`, e);
+	} catch (err) {
+		// TODO: change to import('svelte/compiler').Warning after upgrading to Svelte 5
+		const e = (/** @type {any} */ (err));
+		console.warn(buildExtendedLogMessage(e), e.frame);
+		console.info(e.stack);
 	}
 }
 
@@ -327,11 +330,34 @@ export function update_js_file(file_path, transform_code) {
 		const content = fs.readFileSync(file_path, 'utf-8');
 		const updated = transform_code(content, file_path.endsWith('.ts'), file_path);
 		fs.writeFileSync(file_path, updated, 'utf-8');
-	} catch (e) {
-		console.error(`Error updating ${file_path}:`, e);
+	} catch (err) {
+		// TODO: change to import('svelte/compiler').Warning after upgrading to Svelte 5
+		const e = (/** @type {any} */ (err));
+		console.warn(buildExtendedLogMessage(e), e.frame);
+		console.info(e.stack);
 	}
 }
 
+/**
+ * @param {any} w
+ */
+export function buildExtendedLogMessage(w) {
+	const parts = [];
+	if (w.filename) {
+		parts.push(w.filename);
+	}
+	if (w.start) {
+		parts.push(':', w.start.line, ':', w.start.column);
+	}
+	if (w.message) {
+		if (parts.length > 0) {
+			parts.push(' ');
+		}
+		parts.push(w.message);
+	}
+	return parts.join('');
+}
+
 /**
  * Updates the tsconfig/jsconfig.json file with the provided function.
  * @param {(content: string) => string} update_tsconfig_content