Skip to content

Commit 1069225

Browse files
committed
use the domain directly
1 parent 3b7d7ad commit 1069225

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

src/common/AWSClient4.cpp

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ AWSClient4::~AWSClient4() {
7575
delete[] awsKeyID;
7676
}
7777

78-
char* AWSClient4::createHost() {
79-
// return "example.com";
80-
return awsDomain;
81-
}
8278

8379
char* AWSClient4::createCanonicalHeaders() {
8480
// headers, alphabetically sorted, lowercase, eg: key:value
@@ -88,7 +84,7 @@ char* AWSClient4::createCanonicalHeaders() {
8884
// x-amz-date:date
8985
char canonical_headers[500] = "";
9086
sprintf(canonical_headers, "%scontent-type:%s\n", canonical_headers, contentType);
91-
sprintf(canonical_headers, "%shost:%s\n", canonical_headers, createHost());
87+
sprintf(canonical_headers, "%shost:%s\n", canonical_headers, awsDomain);
9288
// sprintf(canonical_headers, "%srange:bytes=0-9\n", canonical_headers); // s3
9389
sprintf(canonical_headers, "%sx-amz-content-sha256:%s\n", canonical_headers, payloadHash);
9490
sprintf(canonical_headers, "%sx-amz-date:%sT%sZ\n\n", canonical_headers, awsDate, awsTime);
@@ -100,7 +96,7 @@ char* AWSClient4::createRequestHeaders(char* signature) {
10096
sprintf(headers, "%sContent-Type: %s\r\n", headers, contentType);
10197
sprintf(headers, "%sConnection: close\r\n", headers);
10298
sprintf(headers, "%sContent-Length: %d\r\n", headers, strlen(payload.getCStr()));
103-
sprintf(headers, "%sHost: %s\r\n", headers, createHost());
99+
sprintf(headers, "%sHost: %s\r\n", headers, awsDomain);
104100
sprintf(headers, "%sx-amz-content-sha256: %s\r\n", headers, payloadHash);
105101
sprintf(headers, "%sx-amz-date: %sT%sZ\r\n", headers, awsDate, awsTime);
106102
sprintf(headers, "%sAuthorization: AWS4-HMAC-SHA256 Credential=%s/%s/%s/%s/aws4_request,SignedHeaders=%s,Signature=%s\r\n", headers, awsKeyID, awsDate, awsRegion, awsService, signedHeaders, signature);
@@ -216,19 +212,19 @@ char* AWSClient4::createRequest(MinimalString &reqPayload) {
216212
char *headers = createRequestHeaders(signature);
217213

218214
// get the host/domain
219-
char *host = createHost();
215+
// char *host = createHost();
220216

221217
// create the request with all the vars
222-
char* request = new char[strlen(method) + strlen(host) + strlen(awsPath) + strlen(headers) + strlen(reqPayload.getCStr()) + 16]();
218+
char* request = new char[strlen(method) + strlen(awsDomain) + strlen(awsPath) + strlen(headers) + strlen(reqPayload.getCStr()) + 16]();
223219
sprintf(request, "%s %s HTTP/1.1\r\n%s\r\n%s\r\n\r\n", method, awsPath, headers, reqPayload.getCStr());
224220

225221
return request;
226222
}
227223

228224
char* AWSClient4::sendData(const char* data) {
229-
char* server = createHost();
225+
// char* server = createHost();
230226
int port = httpS ? 443 : 80;
231-
char* response = httpClient->send(data, server, port);
232-
delete[] server;
227+
char* response = httpClient->send(data, awsDomain, port);
228+
// delete[] server;
233229
return response;
234230
}

0 commit comments

Comments
 (0)