[mcs] Initializers with parameters scope and primary constructors

Author: marek-safar

mcs/errors/cs0136-18.cs

@@ -0,0 +1,13 @@
+// CS0136: A local variable named `arg' cannot be declared in this scope because it would give a different meaning to `arg', which is already used in a `parent or current' scope to denote something else
+// Line: 11
+
+using System;
+
+class A (Func<int, int> barg)
+{
+}
+
+class B (int arg) 
+	: A ((arg) => 1)
+{
+}

mcs/errors/cs0136-19.cs

@@ -0,0 +1,13 @@
+// CS0136: A local variable named `arg' cannot be declared in this scope because it would give a different meaning to `arg', which is already used in a `parent or current' scope to denote something else
+// Line: 11
+
+using System;
+
+partial class PC
+{
+    Func<int, int> f = (arg) => 1;
+}
+
+partial class PC (int arg) 
+{
+}

mcs/mcs/anonymous.cs

@@ -1321,16 +1321,28 @@ protected virtual ParametersCompiled ResolveParameters (ResolveContext ec, TypeI
 			return Parameters;
 		}
 
-		protected override Expression DoResolve (ResolveContext ec)
+		protected override Expression DoResolve (ResolveContext rc)
 		{
-			if (ec.HasSet (ResolveContext.Options.ConstantScope)) {
-				ec.Report.Error (1706, loc, "Anonymous methods and lambda expressions cannot be used in the current context");
+			if (rc.HasSet (ResolveContext.Options.ConstantScope)) {
+				rc.Report.Error (1706, loc, "Anonymous methods and lambda expressions cannot be used in the current context");
 				return null;
 			}
 
 			//
-			// Set class type, set type
+			// Update top-level block generated duting parsing with actual top-level block
 			//
+			if (rc.HasAny (ResolveContext.Options.FieldInitializerScope | ResolveContext.Options.BaseInitializer)) {
+				var tb = rc.ConstructorBlock.ParametersBlock.TopBlock;
+				if (Block.TopBlock != tb) {
+					Block b = Block;
+					while (b.Parent != Block.TopBlock && b != Block.TopBlock)
+						b = b.Parent;
+
+					b.Parent = tb;
+					tb.IncludeBlock (Block.TopBlock);
+					b.ParametersBlock.TopBlock = tb;
+				}
+			}
 
 			eclass = ExprClass.Value;
 
@@ -1341,7 +1353,7 @@ protected override Expression DoResolve (ResolveContext ec)
 			// 
 			type = InternalType.AnonymousMethod;
 
-			if (!DoResolveParameters (ec))
+			if (!DoResolveParameters (rc))
 				return null;
 
 			return this;

mcs/mcs/class.cs

@@ -1608,8 +1608,12 @@ bool DoDefineBaseType ()
 			// defined after current container
 			//
 			if (class_partial_parts != null) {
-				foreach (var pp in class_partial_parts)
+				foreach (var pp in class_partial_parts) {
+					if (pp.PrimaryConstructorBaseArguments != null)
+						PrimaryConstructorBaseArguments = pp.PrimaryConstructorBaseArguments;
+
 					pp.DoDefineBaseType ();
+				}
 
 			}
 
@@ -2665,7 +2669,7 @@ protected virtual Constructor DefineDefaultConstructor (bool is_static)
 
 			AddConstructor (c, true);
 			if (PrimaryConstructorBlock == null) {
-				c.Block = new ToplevelBlock (Compiler, c.ParameterInfo, Location) {
+				c.Block = new ToplevelBlock (Compiler, parameters, Location) {
 					IsCompilerGenerated = true
 				};
 			} else {

mcs/mcs/statement.cs

@@ -3673,6 +3673,9 @@ public ToplevelBlock TopBlock {
 			get {
 				return top_block;
 			}
+			set {
+				top_block = value;
+			}
 		}
 
 		public bool Resolved {
@@ -4312,6 +4315,21 @@ public bool GetLocalName (string name, Block block, ref INamedBlockVariable vari
 			return false;
 		}
 
+		public void IncludeBlock (ToplevelBlock block)
+		{
+			if (block.names != null) {
+				foreach (var n in block.names) {
+					var variable = n.Value as INamedBlockVariable;
+					if (variable != null) {
+						AddLocalName (n.Key, variable, false);
+						continue;
+					}
+
+					throw new NotImplementedException ();
+				}
+			}
+		}
+
 		// <summary>
 		//   This is used by non-static `struct' constructors which do not have an
 		//   initializer - in this case, the constructor must initialize all of the

mcs/tests/test-primary-ctor-09.cs

@@ -0,0 +1,30 @@
+using System;
+
+class A (Func<int, int> barg)
+{
+	public Func<int, int> BaseArg = barg;
+}
+
+partial class PC
+{
+	public Func<int, int> f1 = (a) => arg;
+}
+
+partial class PC (int arg) 
+	: A ((a) => arg)
+{
+}
+
+class X
+{
+	public static int Main ()
+	{
+		if (new PC (3).f1 (4) != 3)
+			return 1;
+
+		if (new PC (3).BaseArg (4) != 3)
+			return 2;
+
+		return 0;
+	}
+}

mcs/tests/ver-il-net_4_5.xml

@@ -67997,6 +67997,37 @@
       </method>
     </type>
   </test>
+  <test name="test-primary-ctor-09.cs">
+    <type name="A">
+      <method name="Void .ctor(Func`2)" attrs="6278">
+        <size>14</size>
+      </method>
+    </type>
+    <type name="PC">
+      <method name="Void .ctor(Int32)" attrs="6278">
+        <size>50</size>
+      </method>
+    </type>
+    <type name="X">
+      <method name="Int32 Main()" attrs="150">
+        <size>70</size>
+      </method>
+      <method name="Void .ctor()" attrs="6278">
+        <size>7</size>
+      </method>
+    </type>
+    <type name="PC+&lt;f1&gt;c__AnonStorey0">
+      <method name="Int32 &lt;&gt;m__0(Int32)" attrs="131">
+        <size>14</size>
+      </method>
+      <method name="Int32 &lt;&gt;m__1(Int32)" attrs="131">
+        <size>14</size>
+      </method>
+      <method name="Void .ctor()" attrs="6278">
+        <size>7</size>
+      </method>
+    </type>
+  </test>
   <test name="test-static-using-01.cs">
     <type name="A.B.X">
       <method name="Int32 Test()" attrs="150">