update branch #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l modifying POST request - Add additional ACL check to make sure user also has permissions to send comment email - Add unit test coverage for this functionality
-resolve merge conflict
… quote id when applicable #19424
- fix static tests
as written here: https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html the min php version is 7.1.3 but the check in this file was wrong (so also the error messages)
…inconsistent box border #19510
…t work if there is already option with the same number without the zero [REST API] #19451
Accepted Public Pull Requests: - #19288: fixed typos for zero order credit memo feature (by @viral-wagento) - #19601: Deprecated ArrayInterface in favour of ancestor OptionSourceInterface (by @sivaschenko) - #19599: Update readme to use correct module name (by @gil--) - #19574: Fixed 19573: Alignment Issue when create a new email template admin (by @suryakant-krish) - #19580: Fixed 19579: Input type import file alignment issue. (by @suryakant-krish) - #19554: added config for wishlist sidebar in config (by @torhoehn) - #19541: Log jobCode when writing to log with no callback for easier debug (by @craigcarnell) - #19510: Fixed issue 19509 - Catalog bundle product Bundle Items inconsistent box border (by @abrarpathan19) - #19451: Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] (by @SikailoISM) - #19295: Reducing space when there is no message on the page (by @rodrigoobiassi) Fixed GitHub Issues: - #19573: Alignment Issue when create a new email template admin. (reported by @suryakant-krish) has been fixed in #19574 by @suryakant-krish in 2.3-develop branch Related commits: 1. 9143820 2. b1c929d 3. 81bae5c 4. 72438de 5. da8b316 - #19579: Input type import file alignment issue. (reported by @suryakant-krish) has been fixed in #19580 by @suryakant-krish in 2.3-develop branch Related commits: 1. 9143820 2. 1d7971e - #19509: Catalog bundle product Bundle Items inconsistent box border (reported by @abrarpathan19) has been fixed in #19510 by @abrarpathan19 in 2.3-develop branch Related commits: 1. 529b086 2. 43c1ba8 3. 9ec154e 4. d93f023 - #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) (reported by @zexperto) has been fixed in #19451 by @SikailoISM in 2.3-develop branch Related commits: 1. 7e55ad5
Accepted Public Pull Requests: - #19659: Fix issue #19657- Select Option Space issue into backend (by @speedy008) - #19617: Additional Cache Management title (by @thomas-blackbird) - #19583: MAGETWO-96618: JS files relocation BC in 2.3 too (by @rbayet) - #19569: Fixed issue with Base Currency for website is CND when PayPal Payflow� (by @jignesh-baldha) - #19249: fix php 7.2 error : Countable interface not implemented (by @gmachure) - #19164: Fixed subscribe to newsletter if you already have an account issue #8952 -2.3 develop (by @ravi-chandra3197) - #18832: Cancel expired orders using OrderManagementInterface (by @JeroenVanLeusden) - #18768: Collect totals in placeOrder when no paymentMethod provided (by @pmclain) - #18521: [Forwardport] Added checks to see if the payment is available (by @gelanivishal) Fixed GitHub Issues: - #19657: Select Option Space issue into backend (reported by @speedy008) has been fixed in #19659 by @speedy008 in 2.3-develop branch Related commits: 1. 29f6be1 - #16302: JS files located outside the web/js directory (reported by @BenSpace48) has been fixed in #19583 by @rbayet in 2.3-develop branch Related commits: 1. f38f09f - #19291: JS files relocation inside the web/js directory not BC in 2.3.x (reported by @rbayet) has been fixed in #19583 by @rbayet in 2.3-develop branch Related commits: 1. f38f09f - #19247: Magento 2 : fix php 7.2 error : Countable interface not implemented (reported by @gmachure) has been fixed in #19249 by @gmachure in 2.3-develop branch Related commits: 1. f1e7e3f 2. a7b9122 - #8952: You can't subscribe to newsletter if you already have an account (reported by @loomdecor) has been fixed in #19164 by @ravi-chandra3197 in 2.3-develop branch Related commits: 1. 78b694f 2. ebfffe4 3. b8941a8 - #16050: Authorize.net (reported by @milenavasic) has been fixed in #18768 by @pmclain in 2.3-develop branch Related commits: 1. 7bc9c31 2. 389a16b - #15652: REST API create order POST /V1/orders (reported by @bibiseb) has been fixed in #18521 by @gelanivishal in 2.3-develop branch Related commits: 1. 14b3eaf 2. 3eb6c3e
Fixed issues: MAGETWO-91526 [2.3] Authorize.net Direct Post does not show credit card information MAGETWO-91769 Credit Memo - Wrong tax calculation! #10982 MAGETWO-91639 Tax is added despite customer group changes
[MPI]-port-94437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)