Skip to content

Ft/user profile #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Ft/user profile #22

wants to merge 21 commits into from

Conversation

@OkechEdu
Copy link

@OkechEdu OkechEdu commented Mar 8, 2023

@surajit003 kindly have a look and review i shall add the API serializers

@OkechEdu
added djoser and removed black version as somehow it can't be found b…
60ae094 
…y pip
@OkechEdu
added yarn file
60393f1
@OkechEdu
minor change
541084d
@OkechEdu
included users and profiles apps
2143330
@OkechEdu
started users and profiles apps
3c9d030
@OkechEdu
added security scan vulnebilty cache file to gitignore
f30894c
@OkechEdu
added custom user manager
3afc520
@OkechEdu
Added some required packages
f47406d
@OkechEdu
Added a forms customization for user creation in admin
791c91f
@OkechEdu
Added a custom user manager
e00874c
@OkechEdu
Added custom user model
cbb7d82
@OkechEdu
added user admin
b84c509
@OkechEdu
minor changes to settings files
df1c982
@OkechEdu
minor change
e53802c
@OkechEdu
Added media url and root settings
4b8b5c1
@OkechEdu
Added a folder for media files
bfcfc4f
@OkechEdu
added signals for profile creation instance
ee11db2
@OkechEdu
Added the user profile model
80a329c
@OkechEdu
minor change
7213dd4
@OkechEdu
minor changes to settings file
ac0768b
@OkechEdu
added pillow package for ImageField management
75f73aa
@surajit003
Copy link
Owner

surajit003 commented Mar 8, 2023

@OkechEdu - LGTM. Resolve the conflicts and it should be fine.
Also, in this project, I am not using drf serializers.
Pydantic is what is being used for serialization/de-serialization and validation
You can look at the crm app for the app structure.

@surajit003
Copy link
Owner

surajit003 commented Mar 8, 2023

@OkechEdu - Please also rebase with master. I have updated the CI script and added linter.

surajit003
surajit003 reviewed Mar 8, 2023
View reviewed changes
README.md
3. Supply Chain Management (SCM) - TODO
4. Inventory Management - TODO
5. Accounting/Financial Management - TODO
6. User Management/ Authentication - Ongoing
Copy link
Owner

@surajit003 surajit003 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need to add here.. as this is a feature which will be in all these products.

Copy link
Author

@OkechEdu OkechEdu Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajit003 ok.

@OkechEdu
Copy link
Author

OkechEdu commented Mar 10, 2023

@OkechEdu - LGTM. Resolve the conflicts and it should be fine. Also, in this project, I am not using drf serializers. Pydantic is what is being used for serialization/de-serialization and validation You can look at the crm app for the app structure.

@surajit003 cool this is well noted. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surajit003 surajit003 surajit003 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OkechEdu @surajit003