Add blst_fp12 deserialization blst_fp12_from_bendian#167
Open
emlowe wants to merge 2 commits intosupranational:masterfrom
Open
Add blst_fp12 deserialization blst_fp12_from_bendian#167emlowe wants to merge 2 commits intosupranational:masterfrom
blst_fp12 deserialization blst_fp12_from_bendian#167emlowe wants to merge 2 commits intosupranational:masterfrom
Conversation
emlowe
changed the title
blst_fp12_from_bendianblst_fp12 deserialization blst_fp12_from_bendian
Collaborator
|
Come on! It's not like we don't know it's missing :-) :-) :-) But on a serious note, there is a reason for why deserialization is not implemented. Because there is no specification and we don't want to give an impression that there is. Well, maybe there is now, maybe even a draft, in which case it would be more appropriate to simply provide a reference. Serialization was added to aid the cross-checking with other libraries, but not for communications, which would require a specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blst_fp12 has a serialization function
blst_bendian_from_fp12- but was missing the corresponding deserialization function.This PR adds
blst_fp12_from_bendianfor this purpose.