Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream protocol version #342

Open
benbjohnson opened this issue Jun 14, 2023 · 0 comments
Open

Add stream protocol version #342

benbjohnson opened this issue Jun 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@benbjohnson
Copy link
Collaborator

benbjohnson commented Jun 14, 2023

Currently, if a replica running an older version of LiteFS connects to a newer version of LiteFS which has new stream frame types, it will error out with:

disconnected from primary with error, retrying: next frame: invalid stream frame type: ...

We should begin versioning the stream protocol so we can explicitly check that the accepted version when a node first connects.

We should keep attempting to connect (in case the primary changes to a different version), however, the error message could be improved. We could also increase the retry the delay so we aren't spamming logs so much.

@benbjohnson benbjohnson added the enhancement New feature or request label Jun 14, 2023
@benbjohnson benbjohnson added this to the v0.5.0 milestone Jun 14, 2023
@benbjohnson benbjohnson modified the milestones: v0.5.0, v0.5.1 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant