Added error status codes and made response more consistant

Author: drhurdle

server/controllers/authController.js

@@ -9,25 +9,25 @@ exports.authenticate = function(req, res) {
   var password = req.body.password;
 
   if (!username || !password) {
-    return res.json({Message : "Username and Password required"});
+    return res.status(422).json({message : "Username and Password required"});
   }
 
   User.filter({username:username}).run().then(function(userArray){
 
     var user = userArray[0];
 
     if (!user) {
-      return res.json({Message : "The username is incorrect"});
+      return res.status(422).json({message : "This username does not exist"});
     }
 
     User.comparePassword(password, user, function (err, valid){
 
       if (err) {
-        return res.json({Message : err});
+        return res.status(422).json({message : err});
       }
 
       if (!valid) {
-        return res.json({Message : "The username or password is incorrect"});
+        return res.status(422).json({message : "The username or password is incorrect"});
       } else {
         res.json({
           user: user,

server/controllers/userController.js

@@ -7,11 +7,11 @@ var tokenAuth = require('../services/tokenAuth');
 
 exports.register = function(req , res){
 
-	if(!req.body.username){return res.json({Error : "Username is Required"});}
-	if(!req.body.password){return res.json({Error : "Password is Required"});}
+	if(!req.body.username){return res.status(422).json({message : "Username is Required"});}
+	if(!req.body.password){return res.status(422).json({message : "Password is Required"});}
 
 	User.filter({username:req.body.username}).run().then(function(userArray){
-		if(userArray[0]){return res.json({Error : "Username is in use"});}
+		if(userArray[0]){return res.status(422).json({message : "Username is in use"});}
 
 
 		var user = new User(req.body);

server/policies/isAuthorized.js

@@ -16,15 +16,15 @@ module.exports = function (req, res, next) {
       }
 
     } else {
-      return res.json({err: 'Format is Authorization: Bearer [token]'});
+      return res.status(400).json({message: 'Format is Authorization: Bearer [token]'});
     }
 
   } else {
-    return res.json({err: 'No Authorization header was found'});
+    return res.status(400).json({message: 'No Authorization header was found'});
   }
 
   tokenAuth.verify(token, function (err, token) {
-    if (err) return res.json({err: 'Invalid Token!'});
+    if (err) return res.status(401).json({message: 'Invalid Token!'});
     req.token = token; 
     next();
   });

server/policies/isCurrentUser.js

@@ -4,7 +4,7 @@ module.exports = function(req, res, next) {
   var currentUserId = req.token.id;
 
   if (userId != currentUserId) {
-    return res.json({Error : 'You are not allowed to do that'});
+    return res.status(401).json({message : 'You are not allowed to do that'});
   }
 
   next();