Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate CSS rules for colors #713

Open
tomaskikutis opened this issue Nov 9, 2022 · 2 comments
Open

Duplicate CSS rules for colors #713

tomaskikutis opened this issue Nov 9, 2022 · 2 comments
Labels
bug

Comments

@tomaskikutis
Copy link
Member

I counted 29 instances of the same class declared.
image
@fritzSF
Copy link
Collaborator

fritzSF commented Nov 9, 2022

This is because of how it is imported in Superdesk. People are importing separate SCSS files directly from the framework. We need to address it but I'm not sure if it can be completely avoided.

@tomaskikutis
Copy link
Member Author

I see. What about if we port SASS variables to CSS variables and drop all SASS imports of ui-framework from superdesk-client-core, except for the main bundle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fritzSF @tomaskikutis