classlib: Don't pass unprintables in key events #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation says that the char argument of keydown/keyup events is the printable character typed, or nil. We are currently passing an ascii zero character instead - the fix is to pass nil in this case.
|
Fixes #1081 |
telephon
added a commit
that referenced
this pull request
May 30, 2015
…down-events classlib: Don't pass unprintables in key events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation says that the char argument of keydown/keyup events is the printable character typed, or nil. We are currently passing an ascii zero character instead - the fix is to pass nil in this case.