-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unwrap()
from stats related functions
#289
Conversation
#290 is to fix the test failure |
@burmecia, thanks for your work. Where can I follow the updates of the new release? |
We're preparing a new release and it should be ready soon, you can check it on the release page. Just a note once the new version of Wrappers is release it sill needed to be included in Supabase Postgres image to available on Supabase platform, this will take some time. |
@burmecia I can confirm this problem still happens. I've tried to upgrade our service to the latest version(15.1.1.76). But I still need to execute the SQL in the studio client; otherwise, the call via JS SDK will fail. |
@burmecia Does this version(15.1.1.76) include this change? |
not yet, that |
What kind of change does this PR introduce?
This PR is to remove
unwrap()
call from stats related functions. This also caused failure when using API to access foreign tables in some cases.What is the current behavior?
Currently, it is hard to troubleshot when the panic is caused by
unwrap()
call.What is the new behavior?
Replace
unwrap()
withexpect()
or remove it if possible.Additional context
N/A