Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Helpers.parse_secret/2 to handle nil or empty secrets #324

Closed
abc3 opened this issue Mar 18, 2024 · 0 comments · Fixed by #326
Closed

Extend Helpers.parse_secret/2 to handle nil or empty secrets #324

abc3 opened this issue Mar 18, 2024 · 0 comments · Fixed by #326
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@abc3
Copy link
Member

abc3 commented Mar 18, 2024

Currently, parse_secret/2 handles cases only if the secret is SCRAM-SHA-256 or MD5, otherwise, the ClientHandler will crash with an error.
@abc3 abc3 added bug Something isn't working good first issue Good for newcomers labels Mar 18, 2024
@J0 J0 mentioned this issue Mar 20, 2024
Merged
1 task
@abc3 abc3 closed this as completed in #326 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle invalid secret formats in parse_secret supabase/supavisor
1 participant
@abc3