Fix: handle non-standard and non-JSON error responses without AttributeError - #1577
Open
Vishv07 wants to merge 1 commit into
Open
Fix: handle non-standard and non-JSON error responses without AttributeError#1577Vishv07 wants to merge 1 commit into
Vishv07 wants to merge 1 commit into
Conversation
…ut AttributeError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an
AttributeErrorinstorage3where non-2xx responses that lackmessage,error, orstatusCodekeys in their JSON body (or return non-JSON payloads like HTML 502/504 gateway errors) crashed with'dict' object has no attribute 'text'or uncaughtJSONDecodeError.Changes
_async/file_api.py,_async/bucket.py, and_synccounterparts:(KeyError, ValueError)when decoding error response JSON.exc.response.textinstead ofresp.text.exc.response.status_codetoStorageApiError.test_client.pyandtest_bucket.py(both async and sync).Verification
src/storagepass.mypycheck passes with 0 issues.ruff checkandruff formatpass cleanly.