fix(realtime): terminate web worker on disconnect #1903
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Fixes a critical memory leak in
RealtimeClientwhere Web Workers created with theworker: trueoption were never terminated on disconnect, causing workers to accumulate indefinitely in long-running applications.What changed?
_terminateWorker()inRealtimeClient.tsthat properly terminates the Web Worker with error handling_teardownConnection()to call_terminateWorker()during connection cleanupWhy was this change needed?
Web Workers were being created in
_startWorkerHeartbeat()(line 691) but never terminated in_teardownConnection()(line 628-649). Each disconnect/reconnect cycle would leak one worker, causing memory accumulation over time.Impact:
RealtimeClientwithworker: trueoptionReproduction:
Closes #1902
📸 Screenshots/Examples
Before this fix:
After this fix:
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting📝 Additional notes