fix: improve error message for insufficient privilege

Author: fenos

src/storage/database/knex.ts

@@ -798,10 +798,7 @@ export class DBError extends StorageBackendError implements RenderableError {
   static fromDBError(pgError: DatabaseError, query?: string) {
     switch (pgError.code) {
       case '42501':
-        return ERRORS.AccessDenied(
-          'new row violates row-level security policy',
-          pgError
-        ).withMetadata({
+        return ERRORS.AccessDenied('Database error: insufficient privilege', pgError).withMetadata({
           query,
           code: pgError.code,
         })

src/test/object.test.ts

@@ -314,7 +314,7 @@ describe('testing POST object via multipart upload', () => {
       JSON.stringify({
         statusCode: '403',
         error: 'Unauthorized',
-        message: 'new row violates row-level security policy',
+        message: 'Database error: insufficient privilege',
       })
     )
   })
@@ -800,7 +800,7 @@ describe('testing POST object via binary upload', () => {
       JSON.stringify({
         statusCode: '403',
         error: 'Unauthorized',
-        message: 'new row violates row-level security policy',
+        message: 'Database error: insufficient privilege',
       })
     )
   })
@@ -1672,7 +1672,7 @@ describe('testing generating signed URL for upload', () => {
       JSON.stringify({
         statusCode: '403',
         error: 'Unauthorized',
-        message: 'new row violates row-level security policy',
+        message: 'Database error: insufficient privilege',
       })
     )
     // Ensure that row does not exist in database.

src/test/rls_tests.yaml

@@ -54,15 +54,15 @@ tests:
     asserts:
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: bucket.delete
         status: 400
@@ -113,15 +113,15 @@ tests:
     asserts:
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: bucket.delete
         status: 400
@@ -199,11 +199,11 @@ tests:
 
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         policies:
@@ -240,19 +240,19 @@ tests:
     asserts:
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: bucket.delete
         status: 400
         error: 'Bucket not found'
 
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         policies:
@@ -281,7 +281,7 @@ tests:
     asserts:
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: bucket.delete
         status: 400
@@ -322,15 +322,15 @@ tests:
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         policies:
@@ -363,15 +363,15 @@ tests:
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         bucketName: 'bucket_delete_test_{{runId}}'
@@ -406,15 +406,15 @@ tests:
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload.upsert
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         bucketName: 'bucket_to_move_{{runId}}'
@@ -446,7 +446,7 @@ tests:
 
       - operation: bucket.create
         status: 400
-        error: 'new row violates row-level security policy'
+        error: 'Database error: insufficient privilege'
 
       - operation: upload
         bucketName: 'bucket_{{runId}}'
@@ -457,7 +457,7 @@ tests:
         useExistingBucketName: 'bucket_{{runId}}'
         objectName: 'object_{{runId}}.txt'
         status: 400
-        message: 'new row violates row-level security policy'
+        message: 'Database error: insufficient privilege'
 
       - operation: upload
         bucketName: 'bucket_to_copy_{{runId}}'