fix: partition removal tests

Author: edgurgel

test/realtime/messages_test.exs

@@ -192,7 +192,7 @@ defmodule Realtime.MessagesTest do
       to_keep =
         Enum.reject(
           messages,
-          &(NaiveDateTime.compare(limit, &1.inserted_at) == :gt)
+          &(NaiveDateTime.compare(NaiveDateTime.beginning_of_day(limit), &1.inserted_at) == :gt)
         )
 
       assert :ok = Messages.delete_old_messages(conn)

test/realtime/tenants/janitor/maintenance_task_test.exs

@@ -15,9 +15,15 @@ defmodule Realtime.Tenants.Janitor.MaintenanceTaskTest do
   end
 
   test "cleans messages older than 72 hours and creates partitions", %{tenant: tenant} do
+    {:ok, conn} = Database.connect(tenant, "realtime_test", :stop)
+
     utc_now = NaiveDateTime.utc_now()
     limit = NaiveDateTime.add(utc_now, -72, :hour)
 
+    date_start = Date.utc_today() |> Date.add(-10)
+    date_end = Date.utc_today()
+    create_messages_partitions(conn, date_start, date_end)
+
     messages =
       for days <- -5..0 do
         inserted_at = NaiveDateTime.add(utc_now, days, :day)
@@ -27,12 +33,11 @@ defmodule Realtime.Tenants.Janitor.MaintenanceTaskTest do
 
     to_keep =
       messages
-      |> Enum.reject(&(NaiveDateTime.compare(limit, &1.inserted_at) == :gt))
+      |> Enum.reject(&(NaiveDateTime.compare(NaiveDateTime.beginning_of_day(limit), &1.inserted_at) == :gt))
       |> MapSet.new()
 
     assert MaintenanceTask.run(tenant.external_id) == :ok
 
-    {:ok, conn} = Database.connect(tenant, "realtime_test", :stop)
     {:ok, res} = Repo.all(conn, from(m in Message), Message)
 
     verify_partitions(conn)
@@ -80,7 +85,7 @@ defmodule Realtime.Tenants.Janitor.MaintenanceTaskTest do
 
   defp verify_partitions(conn) do
     today = Date.utc_today()
-    yesterday = Date.add(today, -1)
+    yesterday = Date.add(today, -3)
     future = Date.add(today, 3)
     dates = Date.range(yesterday, future)
 

test/realtime/tenants/janitor_test.exs

@@ -31,6 +31,14 @@ defmodule Realtime.Tenants.JanitorTest do
         end
       )
 
+    date_start = Date.utc_today() |> Date.add(-10)
+    date_end = Date.utc_today()
+
+    Enum.map(tenants, fn tenant ->
+      {:ok, conn} = Database.connect(tenant, "realtime_test", :stop)
+      create_messages_partitions(conn, date_start, date_end)
+    end)
+
     start_supervised!(
       {Task.Supervisor,
        name: Realtime.Tenants.Janitor.TaskSupervisor, max_children: 5, max_seconds: 500, max_restarts: 1}
@@ -62,7 +70,7 @@ defmodule Realtime.Tenants.JanitorTest do
 
     to_keep =
       messages
-      |> Enum.reject(&(NaiveDateTime.compare(limit, &1.inserted_at) == :gt))
+      |> Enum.reject(&(NaiveDateTime.compare(NaiveDateTime.beginning_of_day(limit), &1.inserted_at) == :gt))
       |> MapSet.new()
 
     start_supervised!(Janitor)
@@ -105,7 +113,7 @@ defmodule Realtime.Tenants.JanitorTest do
 
     to_keep =
       messages
-      |> Enum.reject(&(NaiveDateTime.compare(limit, &1.inserted_at) == :gt))
+      |> Enum.reject(&(NaiveDateTime.compare(NaiveDateTime.beginning_of_day(limit), &1.inserted_at) == :gt))
       |> MapSet.new()
 
     start_supervised!(Janitor)
@@ -162,7 +170,7 @@ defmodule Realtime.Tenants.JanitorTest do
 
   defp verify_partitions(conn) do
     today = Date.utc_today()
-    yesterday = Date.add(today, -1)
+    yesterday = Date.add(today, -3)
     future = Date.add(today, 3)
     dates = Date.range(yesterday, future)