feat: add additional function create options #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, one sec - wouldn't you want to allow setting multiple configs for |
soedirgo
reviewed
Jul 20, 2021
src/lib/PostgresMetaFunctions.ts
Outdated
| @@ -82,21 +82,32 @@ export default class PostgresMetaFunctions { | |||
| definition, | |||
| rettype = 'void', | |||
| language = 'sql', | |||
| behavior, | |||
There was a problem hiding this comment.
Can make VOLATILE the default here instead
src/lib/PostgresMetaFunctions.ts
Outdated
| }: { | ||
| name: string | ||
| schema?: string | ||
| args?: string[] | ||
| definition: string | ||
| rettype?: string | ||
| language?: string | ||
| behavior?: 'IMMUTABLE' | 'STABLE' | 'VOLATILE' | ||
| security_definer?: 'false' | 'true' |
There was a problem hiding this comment.
Should we make this a boolean instead?
w3b6x9
force-pushed
the
feat/function-options
branch
from
315ae75 to
934a326
Compare
w3b6x9
commented
Jul 20, 2021
Comment on lines
+26
to
+32
| SELECT | ||
| oid as id, | ||
| (string_to_array(unnest(proconfig), '='))[1] AS param, | ||
| string_to_array((string_to_array(unnest(proconfig), '='))[2], ', ') AS values | ||
| FROM | ||
| pg_proc | ||
| ) p_config ON p_config.id = p.oid |
There was a problem hiding this comment.
@soedirgo not sure why the indentation here is so weird. Looks fine on my local:
There was a problem hiding this comment.
Ah, looks like some tabs starting from line 27. Not a big deal.
w3b6x9
force-pushed
the
feat/function-options
branch
from
934a326 to
03ac6d0
Compare
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
avallete
pushed a commit
that referenced
this pull request
May 13, 2025
feat: add additional function create options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the new behavior?
Add the following options when creating functions: