Add support for aggregate functions #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix whitespace errors reported by pre-commit hook
Fix whitespace errors reported by pre-commit hook
Fix whitespace errors reported by pre-commit hook
Information regarding the aggregate being available for only certain types is already there in the beginning of the aggregates section.
imor
requested changes
May 6, 2025
There was a problem hiding this comment.
Hey @spitfire55, thank you for this PR.
I've pushed some minor fixes and added some review comments but not fully done reviewing yet.
imor
requested changes
May 6, 2025
- Fix AggregateSelection typename to use field instead of sub_field - Create helper function for integer type matching
- Refactoring & simplification - Remove defensive UUID check - Better log & error strings
imor
approved these changes
May 7, 2025
|
@olirice LGTM. Would like to take a quick look. One question I had was if we'd like to hide the aggregates behind a directive similar to total count for performance reasons. |
|
nice work on the pr @spitfire55 Yes I think we should have it setup like |
|
Added the comment directive to guard aggregate usage, similar to totalCount. Docs updated as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add support for aggregates (min, max, avg, count, sum)
What is the current behavior?
No support
What is the new behavior?
Standard support. I'm sure there are edge cases I haven't tested or covered, but this is a good first shot at it.
Additional context
N/A