fix: trim space for migration version

Author: sweatybridge

internal/seed/buckets/buckets_test.go

@@ -30,6 +30,7 @@ public = false`
 		bucketPath := filepath.Join(utils.SupabaseDirPath, "images")
 		require.NoError(t, fsys.Mkdir(bucketPath, 0755))
 		// Setup mock api
+		defer gock.OffAll()
 		gock.New(utils.Config.Api.ExternalUrl).
 			Get("/storage/v1/bucket").
 			Reply(http.StatusOK).
@@ -54,6 +55,7 @@ public = false`
 
 	t.Run("ignores unconfigured buckets", func(t *testing.T) {
 		// Setup mock api
+		defer gock.OffAll()
 		gock.New(utils.Config.Api.ExternalUrl).
 			Get("/storage/v1/bucket").
 			Reply(http.StatusOK).

internal/utils/tenant/database_test.go

@@ -13,56 +13,55 @@ import (
 )
 
 func TestGetDatabaseVersion(t *testing.T) {
-	t.Run("retrieves database version successfully", func(t *testing.T) {
-		token := apitest.RandomAccessToken(t)
-		t.Setenv("SUPABASE_ACCESS_TOKEN", string(token))
+	// Setup valid access token
+	token := apitest.RandomAccessToken(t)
+	t.Setenv("SUPABASE_ACCESS_TOKEN", string(token))
+	// Setup valid project ref
+	projectRef := apitest.RandomProjectRef()
 
+	t.Run("retrieves database version successfully", func(t *testing.T) {
+		// Setup mock api
 		defer gock.OffAll()
-		projectRef := apitest.RandomProjectRef()
-		mockPostgres := api.V1ProjectWithDatabaseResponse{Id: projectRef}
+		mockPostgres := api.V1ProjectWithDatabaseResponse{}
 		mockPostgres.Database.Version = "14.1.0.99"
 		gock.New(utils.DefaultApiHost).
 			Get("/v1/projects/" + projectRef).
 			Reply(http.StatusOK).
 			JSON(mockPostgres)
-
+		// Run test
 		version, err := GetDatabaseVersion(context.Background(), projectRef)
-
+		// Check error
 		assert.NoError(t, err)
 		assert.Equal(t, "14.1.0.99", version)
 		assert.Empty(t, apitest.ListUnmatchedRequests())
 	})
 
 	t.Run("handles project not found", func(t *testing.T) {
-		token := apitest.RandomAccessToken(t)
-		t.Setenv("SUPABASE_ACCESS_TOKEN", string(token))
-
+		// Setup mock api
 		defer gock.OffAll()
 		projectRef := apitest.RandomProjectRef()
 		gock.New(utils.DefaultApiHost).
 			Get("/v1/projects/" + projectRef).
 			Reply(http.StatusNotFound)
-
+		// Run test
 		version, err := GetDatabaseVersion(context.Background(), projectRef)
-
+		// Check error
 		assert.ErrorContains(t, err, "unexpected retrieve project status 404:")
 		assert.Empty(t, version)
 		assert.Empty(t, apitest.ListUnmatchedRequests())
 	})
 
 	t.Run("handles empty database version", func(t *testing.T) {
-		token := apitest.RandomAccessToken(t)
-		t.Setenv("SUPABASE_ACCESS_TOKEN", string(token))
-
+		// Setup mock api
 		defer gock.OffAll()
 		projectRef := apitest.RandomProjectRef()
 		gock.New(utils.DefaultApiHost).
 			Get("/v1/projects/" + projectRef).
 			Reply(http.StatusOK).
-			JSON(api.V1ProjectWithDatabaseResponse{Id: projectRef})
-
+			JSON(api.V1ProjectWithDatabaseResponse{})
+		// Run test
 		version, err := GetDatabaseVersion(context.Background(), projectRef)
-
+		// Check error
 		assert.ErrorIs(t, err, errDatabaseVersion)
 		assert.Empty(t, version)
 		assert.Empty(t, apitest.ListUnmatchedRequests())

pkg/config/config.go

@@ -634,7 +634,7 @@ func (c *config) Load(path string, fsys fs.FS, overrides ...ConfigEditor) error
 		}
 	}
 	if version, err := fs.ReadFile(fsys, builder.StorageMigrationPath); err == nil && len(version) > 0 {
-		c.Storage.TargetMigration = string(version)
+		c.Storage.TargetMigration = strings.TrimSpace(string(version))
 	}
 	if version, err := fs.ReadFile(fsys, builder.EdgeRuntimeVersionPath); err == nil && len(version) > 0 {
 		c.EdgeRuntime.Image = replaceImageTag(Images.EdgeRuntime, string(version))