Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit irispy-lmsal as an affiliated package #414

Closed
7 tasks done
nabobalis opened this issue Apr 12, 2024 · 6 comments · Fixed by #433
Closed
7 tasks done

Submit irispy-lmsal as an affiliated package #414

nabobalis opened this issue Apr 12, 2024 · 6 comments · Fixed by #433
Assignees
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review

Comments

@nabobalis
Copy link
Contributor

nabobalis commented Apr 12, 2024

Package Details

Description of Package

A Python package that provides the tools to read in and analyze data from the IRIS solar-observing satellite.

Package Review

Editor Submission Checklist

  • Is the submission appropriate (compatible with the SunPy CoC)?
  • Does the project have an appropriate license?
  • Is the project in an online version control system?
  • Does the project provide a Python interface?
  • Is the project on PyPI?
  • Is the project useful to the solar physics community?
  • Version that was reviewed: v0.2.0

Instructions to Reviewer

Please copy the following and select the ranking for each criteria, the full review criteria can be found here:

* Functionality           : General Package / Specialized Package / Not Relevant
* Integration             : Well integrated / Partially Integrated / Minimal Integration
* Documentation           : Extensive / Some / Little
* Testing                 : Excellent / Good / Needs Work
* Duplication             : None / Some / Major
* Community               : Excellent / Good / Needs Work
* Development Status      : Stable / Subject to Change / Low Activity / Needs Work
@nabobalis nabobalis added the Affiliated Package Review An issue submitting a new Affiliated Package for review label Apr 12, 2024
@Cadair
Copy link
Member

Cadair commented Apr 30, 2024

@nabobalis Thanks for the submission. The package looks good and it's great to see more officially supported instrument packages emerging. My review is below, the only reason I have marked Community down from excellent is that I can't see a code of conduct in the repo and/or the documentation which is a requirement, if you can add that I will happily bump the review and we can accept irispy-lmsal.

  • Functionality :
  • Integration : Well integrated
  • Documentation : Extensive
  • Testing : Good
  • Duplication : None
  • Community : Needs Work
  • Development Status : Subject to Change

@nabobalis
Copy link
Contributor Author

nabobalis commented May 1, 2024

I have opened/merged LM-SAL/irispy-lmsal#46 that adds a COC to the repo. It is based on the sunpy one with changes. Unsure if this is the best COC to use for non-sunpy project projects.

@Cadair
Copy link
Member

Cadair commented Jun 9, 2024

With that change, here is the final review:

  • Functionality :
  • Integration : Well integrated
  • Documentation : Extensive
  • Testing : Good
  • Duplication : None
  • Community : Excellent
  • Development Status : Subject to Change

@nabobalis can you push a release after that CoC change and then you want to make the PR to the page with this review?

@nabobalis
Copy link
Contributor Author

I tagged a release: https://github.com/LM-SAL/irispy-lmsal/releases/tag/v0.2.1

The CI wheels are turning.

@nabobalis
Copy link
Contributor Author

Anything else to be done here?

@Cadair
Copy link
Member

Cadair commented Sep 9, 2024

I need to PR to the site with this and also #431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants