-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit irispy-lmsal
as an affiliated package
#414
Comments
@nabobalis Thanks for the submission. The package looks good and it's great to see more officially supported instrument packages emerging. My review is below, the only reason I have marked Community down from excellent is that I can't see a code of conduct in the repo and/or the documentation which is a requirement, if you can add that I will happily bump the review and we can accept irispy-lmsal. |
I have opened/merged LM-SAL/irispy-lmsal#46 that adds a COC to the repo. It is based on the sunpy one with changes. Unsure if this is the best COC to use for non-sunpy project projects. |
With that change, here is the final review:
@nabobalis can you push a release after that CoC change and then you want to make the PR to the page with this review? |
I tagged a release: https://github.com/LM-SAL/irispy-lmsal/releases/tag/v0.2.1 The CI wheels are turning. |
Anything else to be done here? |
I need to PR to the site with this and also #431 |
Package Details
Description of Package
A Python package that provides the tools to read in and analyze data from the IRIS solar-observing satellite.
Package Review
Editor Submission Checklist
Instructions to Reviewer
Please copy the following and select the ranking for each criteria, the full review criteria can be found here:
The text was updated successfully, but these errors were encountered: