[FIX] sale_project : create on order when type updated to service

Steps :
Install Sales, Project and Inventory.
Create a Storable Product.
Create a SO with this product, but do not confirm it.
Change this product :
	> Type : Service
	> Sales > Service Tracking : Create a task in SO's project
Confirm the SO.

Issue :
Neither a delivery or a task is created.

Cause :
Confirming the SO calls SO._timesheet_service_generation(),
which filtered its SOLs based on is_service to 'create on order'.
As this field is not updated when changing the type of the product,
the SOL with the service is filtered out.

Fix :
Update SOL_.is_service when changing SOL.product_id.type.

opw-2786655

closes odoo#87042

X-original-commit: a38f544
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Author: auon-odoo

addons/sale_project/models/sale_order.py

@@ -122,12 +122,12 @@ class SaleOrderLine(models.Model):
         index=True, copy=False, help="Task generated by the sales order item")
     is_service = fields.Boolean("Is a Service", compute='_compute_is_service', store=True, compute_sudo=True, help="Sales Order item should generate a task and/or a project, depending on the product settings.")
 
-    @api.depends('product_id')
+    @api.depends('product_id.type')
     def _compute_is_service(self):
         for so_line in self:
             so_line.is_service = so_line.product_id.type == 'service'
 
-    @api.depends('product_id')
+    @api.depends('product_id.type')
     def _compute_product_updatable(self):
         for line in self:
             if line.product_id.type == 'service' and line.state == 'sale':

addons/sale_project/tests/test_sale_project.py

@@ -139,3 +139,24 @@ def test_sale_order_with_project_task(self):
         # service_tracking 'project_only'
         self.assertFalse(so_line_order_only_project.task_id, "Task should not be created")
         self.assertTrue(so_line_order_only_project.project_id, "Sales order line should be linked to newly created project")
+
+    def test_sol_product_type_update(self):
+        partner = self.env['res.partner'].create({'name': "Mur en brique"})
+        sale_order = self.env['sale.order'].with_context(tracking_disable=True).create({
+            'partner_id': partner.id,
+            'partner_invoice_id': partner.id,
+            'partner_shipping_id': partner.id,
+        })
+        self.product_order_service3.type = 'consu'
+        sale_order_line = self.env['sale.order.line'].create({
+            'order_id': sale_order.id,
+            'name': self.product_order_service3.name,
+            'product_id': self.product_order_service3.id,
+            'product_uom_qty': 5,
+            'product_uom': self.product_order_service3.uom_id.id,
+            'price_unit': self.product_order_service3.list_price
+        })
+        self.assertFalse(sale_order_line.is_service, "As the product is consumable, the SOL should not be a service")
+
+        self.product_order_service3.type = 'service'
+        self.assertTrue(sale_order_line.is_service, "As the product is a service, the SOL should be a service")