[video_player] Fix pedantic lints (flutter#2321)

Fix pedantic lints. This fixes some potential race conditions in cases where
futures within some video_player methods weren't being awaited correctly.

Author: Michael Klimushyn

packages/video_player/video_player/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.10.4+1
+
+* Fix pedantic lints. This fixes some potential race conditions in cases where
+  futures within some video_player methods weren't being awaited correctly.
+
 ## 0.10.4
 
 * Port plugin code to use the federated Platform Interface, instead of a MethodChannel directly.

packages/video_player/video_player/analysis_options.yaml

@@ -9,7 +9,7 @@ import 'package:test/test.dart';
 Future<void> main() async {
   final FlutterDriver driver = await FlutterDriver.connect();
   tearDownAll(() async {
-    driver.close();
+    await driver.close();
   });
 
   //TODO(cyanglaz): Use TabBar tabs to navigate between pages after https://github.com/flutter/flutter/issues/16991 is fixed.

packages/video_player/video_player/example/test_driver/video_player_test.dart

@@ -331,15 +331,15 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
     if (!value.initialized || _isDisposed) {
       return;
     }
-    VideoPlayerPlatform.instance.setLooping(_textureId, value.isLooping);
+    await VideoPlayerPlatform.instance.setLooping(_textureId, value.isLooping);
   }
 
   Future<void> _applyPlayPause() async {
     if (!value.initialized || _isDisposed) {
       return;
     }
     if (value.isPlaying) {
-      VideoPlayerPlatform.instance.play(_textureId);
+      await VideoPlayerPlatform.instance.play(_textureId);
       _timer = Timer.periodic(
         const Duration(milliseconds: 500),
         (Timer timer) async {
@@ -358,15 +358,15 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
       await _applySpeed();
     } else {
       _timer?.cancel();
-      VideoPlayerPlatform.instance.pause(_textureId);
+      await VideoPlayerPlatform.instance.pause(_textureId);
     }
   }
 
   Future<void> _applyVolume() async {
     if (!value.initialized || _isDisposed) {
       return;
     }
-    VideoPlayerPlatform.instance.setVolume(_textureId, value.volume);
+    await VideoPlayerPlatform.instance.setVolume(_textureId, value.volume);
   }
 
   /// The position in the current video.
@@ -391,7 +391,7 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
     } else if (position < const Duration()) {
       position = const Duration();
     }
-    VideoPlayerPlatform.instance.seekTo(_textureId, position);
+    await VideoPlayerPlatform.instance.seekTo(_textureId, position);
     value = value.copyWith(position: position);
   }
 

packages/video_player/video_player/lib/video_player.dart

@@ -2,7 +2,7 @@ name: video_player
 description: Flutter plugin for displaying inline video with other Flutter
   widgets on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
-version: 0.10.4
+version: 0.10.4+1
 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player
 
 flutter:

packages/video_player/video_player/pubspec.yaml

@@ -172,7 +172,7 @@ void main() {
       );
       expect(controller.textureId, isNull);
       expect(await controller.position, const Duration(seconds: 0));
-      controller.initialize();
+      await controller.initialize();
 
       await controller.dispose();