Skip to content

Commit

Permalink
Clarify comment and remove TODO
Browse files Browse the repository at this point in the history
The current version of the warning:
```
warning: parser/current is loading parser/ruby27, which recognizes2.7.6-compliant syntax, but you are running 2.7.5.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
```

So I removed the TODO comment because it's outdated.
But I left the actual exclusion in because it will be a recurring issue from time to time.
  • Loading branch information
jeffwidman committed Apr 22, 2022
1 parent 82fcef4 commit d754631
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions common/spec/warning_monkey_patch.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# frozen_string_literal: true

ALLOW_PATTERNS = [
# Ignore parser warnings for ruby 2.7 minor version mismatches
# TODO: Fix these by upgrading to ruby 2.7.3 (requires ubuntu upgrade)
# Ignore parser warnings for ruby 2.7 minor version mismatches.
# This is a recurring issue that occurs whenever the parser gets
# ahead of our installed ruby version.
%r{parser/current is loading parser/ruby27},
/2.7.\d-compliant syntax, but you are running 2.7.\d/,
%r{whitequark/parser}
Expand Down

0 comments on commit d754631

Please sign in to comment.