Make the implementation match std. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `!= 0` instead of `== 1` for testing `isatty`'s return value, so that this code follows std as closely as possible. And update the comments in the Windows implementation to reflect that this code matches what's in current std as well.
|
Btw, just a heads up but rust-lang/rust#119664 has been approved (pending rebase) which changes the implementation slightly due to an issue with msys2's |
|
Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
!= 0instead of== 1for testingisatty's return value, so that this code follows std as closely as possible.And update the comments in the Windows implementation to reflect that this code matches what's in current std as well.