Merge pull request #151 from sumocoders/passing-null-to-strlen-is-deprecated

absumo · web-flow · commit cd226e01ad8b · 2024-05-28T16:42:22.000+02:00
Passing null to strlen is deprecated
diff --git a/src/ValueObject/AbstractFile.php b/src/ValueObject/AbstractFile.php
@@ -239,7 +239,7 @@ public function setPendingDeletion($isPendingDeletion): void
      */
     public function isPendingDeletion(): bool
     {
-        return \strlen($this->oldFileName) > 0 && $this->fileName === null;
+        return !empty($this->oldFileName) && $this->fileName === null;
     }
 
     public function jsonSerialize(): string

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public function setPendingDeletion($isPendingDeletion): void`
`239`	`239`	`*/`
`240`	`240`	`public function isPendingDeletion(): bool`
`241`	`241`	`{`
`242`		`- return \strlen($this->oldFileName) > 0 && $this->fileName === null;`
	`242`	`+ return !empty($this->oldFileName) && $this->fileName === null;`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`public function jsonSerialize(): string`