Consisten environment variable name

Greg Bowler · Greg Bowler · commit 4eceed750b46 · 2021-04-25T10:22:48.000+01:00
diff --git a/.github/workflows/ci-coverage.yml b/.github/workflows/ci-coverage.yml
@@ -20,3 +20,4 @@ jobs:
           args: --coverage-text
         env:
           XDEBUG_MODE: coverage
+          TEST_NAME: Scarlett
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,7 +14,7 @@ jobs:
       - name: PHPUnit Tests
         uses: php-actions/phpunit@v2
         env:
-          name: Scarlett
+          TEST_NAME: Scarlett
         with:
           bootstrap: vendor/autoload.php
           configuration: test/phpunit.xml
diff --git a/test/EnvGreeterTest.php b/test/EnvGreeterTest.php
@@ -14,7 +14,7 @@ public function testEnvFromSystem() {
 		$greeter = new EnvGreeter();
 		self::assertStringContainsString(
 			"Hello, Scarlett",
-			$greeter->greetFromEnv("NAME")
+			$greeter->greetFromEnv("TEST_NAME")
 		);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public function testEnvFromSystem() {`
`14`	`14`	`$greeter = new EnvGreeter();`
`15`	`15`	`self::assertStringContainsString(`
`16`	`16`	`"Hello, Scarlett",`
`17`		`- $greeter->greetFromEnv("NAME")`
	`17`	`+ $greeter->greetFromEnv("TEST_NAME")`
`18`	`18`	`);`
`19`	`19`	`}`
`20`	`20`	`}`