-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error updating SumatraPDF-dev #3020
Comments
For pre-release 3.5.15253 there should be no problem SumatraPDF UpdateYou have the latest version.OKAre you building your own ? |
No, downloaded from sumatrapdfreader.org/prerelease I have the same issue on update 15253 to 15255. (Error 0x2) S.O: Windows 10 LTSC 1809 2019 Thanks for the support. |
Windows 7 x64, SumatraPDF-prerel-64.exe 3.5.15261, Help->Check for updates. |
@sergeevabc |
@GitHubRulesOK, I get a Schannel error in Windows Events log after a failed Sumatra update attempt. It might be related to the handshake issue, e.g. protocol incompatibility when a server refuses to accept TLS 1.2 connections. What URL is used in this case? I can try to connect via Internet Explorer directly. |
I think it downloads the plain text from one of two txt code will be in https://github.com/sumatrapdfreader/sumatrapdf/blob/c8afecac0a3d8c53cbb6e299ed0790ba3f6c7edd/src/UpdateCheck.cpp looking at that it suggests its historic https://www.sumatrapdfreader.org/updatecheck-pre-release.txt which must redirect to above second entry |
Tried Sumatra's 3.5 update check on an entirely different computer, however, is also located in Russia and managed by OS Windows 7 x64. The same 0x2 error there. |
Trying out update checks in different versions of Sumatra:
|
Sumatra, according to this piece of code, uses https://www.sumatrapdfreader.org/updatecheck-pre-release.txt for update check. That server is poorly configured, since only two ciphers are enabled for TLS 1.2. $ sslyze --tlsv1_2 www.sumatrapdfreader.org:443
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 256 ECDH: prime256v1 (256 bits)
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 128 ECDH: prime256v1 (256 bits) These ciphers are not supported on Windows 7, so connections are rejected. Hence the issue. And the solution is to enable more ciphers on the server or to provide another server. For example, the following ciphers are enabled on Github, that's why files hosted here are perfectly available for a wider range of OSes and users.
|
ahh that may explain why my windows 7 devices never have a problem, They were updating afaik (or perhaps I used download page) but not updated daily since it went 64bit only as that older kit is 32 bit, and 7x64 is inactive at present. |
Since the problem with updates has been pinpointed, something should be done about it. Alas, it is not about altering the source files, but about adding missing ciphers to the server configuration. And only the one with an admin access can do it. Who is it? Krzysztof Kowalczyk? Is he even aware of this issue? We need some progress here, or an estimation at least. |
I have been using Sumatra PDF reader for a few years. |
@sergeevabc The website is proxied by Cloudflare. They claim to support more ciphers: https://developers.cloudflare.com/ssl/reference/cipher-suites/supported-cipher-suites/ I find it hard to believe Cloudflare would just break every win7 machine. I see 2 possibilities:
Unfortunately I don't have win7 so it's hard to debug this. Please attach the logs after this happens. Using latest pre-release, Ctrl-K (for command palette) and "show log". This should launch notepad with logs. I have logging in HttpUtil.cpp which should help point the exact code that failed. |
Same Sumatra update fault persists. |
Still working on it, more info in #3306 |
When you try to update SumatraPDF-dev receive the following message: Can't connect to the Internet (error 0x2) (on SumatraPDF pre-release build version 15253, built on 2022-10-11).
The text was updated successfully, but these errors were encountered: