🐛(frontend) preserve title when adding an emoji - #2586
Conversation
The emoji action could reuse a stale document title while a rename was being submitted, replacing the new title with the emoji alone. Keep the latest submitted title in the header and cover the interaction with a regression test. Signed-off-by: fch-aa <21101725+fch-aa@users.noreply.github.com>
5daf3cd to
11938f4
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Walkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized frontend fix preserves the latest page title when an emoji is added immediately after renaming; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #2529
Purpose
Fix a race condition when renaming a newly created page and immediately adding
an emoji. The emoji update previously reused the stale document title, causing
the new title to disappear.
Proposal
Validated with:
corepack yarn lintcorepack yarn test— 55 Yjs and 304 Impress testsVideo
2026-08-14.13-34-09.mp4
External contributions
Thank you for your contribution! 🎉
General requirements
CI requirements
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)AI requirements