fix: don't retry if a transport error is caused by "no native certs f…

[leruaa]

…ound"

Motivation

When proving on the prover network on an environment where the ca-certificates package is missing, the error returned contains "transport error" and is considered as a transient error, so we uselessly retry:

WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...    
WARN Transient transport error when getting program: transport error, retrying...

thread 'main' panicked at src/main.rs:18:49:
called `Result::unwrap()` on an `Err` value: transport error

Caused by:
    no native certs found

Closes #2075

Solution

When the error is caused by "no native certs found", don't retry and return a permanent error:

ERROR Permanent error when getting program: no native certs found    

thread 'main' panicked at src/main.rs:18:49:
called `Result::unwrap()` on an `Err` value: transport error

Caused by:
    no native certs found

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[ratankaliani]

Is there a more type-safe way to handle this with an enum that returns the NoNativeCertsFound error?

I would prefer doing that, rather than parsing the string (which can change).

[leruaa]

I don't think we can, TlsError is not public.

[ratankaliani]

Made a PR to tonic: hyperium/tonic#2209.

Can you update your PR description to be more clear? Can you add a TODO that we can parse this with the TlsError type once a new version with that Tonic PR is merged?

[ratankaliani]

LGTM once you've tested on an Ubuntu machine without ca-certificates.