Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplication in simple extensions schema #404

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Dec 9, 2022

While working on generating deserialization code based on the simple extensions
schema in substrait-io/substrait-rs#27 I got a failing
test on extension_types.yaml.
It seems that the generated deserialization code tripped over the schema for
structure in items in the types array.

Maybe I'm misunderstanding something about the schema here, but I think we can
directly use $ref: "#/$defs/type" for structure here.

According to
https://json-schema.org/understanding-json-schema/reference/object.html#id5:

The additionalProperties keyword is used to control the handling of extra
stuff, that is, properties whose names are not listed in the properties
keyword or match any of the regular expressions in the patternProperties
keyword. By default any additional properties are allowed.

The value of the additionalProperties keyword is a schema that will be used
to validate any properties in the instance that are not matched by
properties or patternProperties. Setting the additionalProperties schema
to false means no additional properties will be allowed.

BREAKING CHANGE: changes to the `text/simple_extensions_schema.yaml` schema file
@mbrobbel mbrobbel changed the title fix!: remove duplication in simple extensions schema fix: remove duplication in simple extensions schema Dec 9, 2022
@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@westonpace westonpace merged commit b7df38d into substrait-io:main Mar 21, 2023
@mbrobbel mbrobbel deleted the simple-extensions-types-fix branch March 21, 2023 16:09
bors bot pushed a commit to substrait-io/substrait-rs that referenced this pull request Apr 4, 2023
…st (#78)

substrait-io/substrait#404 was merged so re-enabling deserialization test of `extension_types.yaml`.
bors bot pushed a commit to substrait-io/substrait-rs that referenced this pull request Apr 4, 2023
…st (#78)

substrait-io/substrait#404 was merged so re-enabling deserialization test of `extension_types.yaml`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants