-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify intention that a single grouping set aggregate does not output a group id #258
Comments
CC @westonpace and @jvanstraten |
The changes above were part of the original intention but somehow failed to make it into the documentation. |
Usually I would scream "breaking change!" but for this one I don't even know, since I'm pretty sure the validator is literally the only implementation doing this "correctly." I can submit a patch if you want. |
Just to clarify,
I'm assuming you mean the case for zero grouping sets (i.e. only measures) as well. |
Yeah, I have no idea how this information got lost. I'm wondering if the reason Weston thinks the same thing I do is that we had a slack discussion post his reading of the docs and the two got merged together. I hunted around for a better description in our docs and as far as I can tell, just failed to write this down... I'm okay calling this a breaking change. On the flipside, it will make more things compliant :D
Yup, good point. A patch would be great. |
We have this currently in the docs:
I think we should update it to clarify two things:
The text was updated successfully, but these errors were encountered: