Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intention that a single grouping set aggregate does not output a group id #258

Closed
jacques-n opened this issue Jul 25, 2022 · 5 comments
Assignees

Comments

@jacques-n
Copy link
Contributor

We have this currently in the docs:

The list of distinct columns from each grouping set (ordered by their first appearance) followed by the list of measures in declaration order, followed by an integer describing the associated particular grouping set the value is derived from.

I think we should update it to clarify two things:

  • In the case of a single grouping set, the integer is not output.
  • The integer is zero-indexed.
@jacques-n
Copy link
Contributor Author

CC @westonpace and @jvanstraten

@jacques-n
Copy link
Contributor Author

The changes above were part of the original intention but somehow failed to make it into the documentation.

@jvanstraten
Copy link
Contributor

Usually I would scream "breaking change!" but for this one I don't even know, since I'm pretty sure the validator is literally the only implementation doing this "correctly." I can submit a patch if you want.

@jvanstraten
Copy link
Contributor

Just to clarify,

In the case of a single grouping set, the integer is not output.

I'm assuming you mean the case for zero grouping sets (i.e. only measures) as well.

@jacques-n
Copy link
Contributor Author

"breaking change!"

Yeah, I have no idea how this information got lost. I'm wondering if the reason Weston thinks the same thing I do is that we had a slack discussion post his reading of the docs and the two got merged together. I hunted around for a better description in our docs and as far as I can tell, just failed to write this down... I'm okay calling this a breaking change. On the flipside, it will make more things compliant :D

I'm assuming you mean the case for zero grouping sets (i.e. only measures) as well.

Yup, good point.

A patch would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants