Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: handle warnings in compileScala as errors #321

Open
vbarua opened this issue Dec 24, 2024 · 0 comments
Open

ci: handle warnings in compileScala as errors #321

vbarua opened this issue Dec 24, 2024 · 0 comments

Comments

@vbarua
Copy link
Member

vbarua commented Dec 24, 2024

When executing ./gradlew check locally on the following #320 the following warning was seen

> Task :spark:compileScala
[Warn] /Users/victor.barua/scratch/substrait-java/spark/src/main/scala/io/substrait/spark/expression/ToAggregateFunction.scala:76:69: match may not be exhaustive.
It would fail on the following input: UNSPECIFIED
one warning found

This should cause a CI failure, but it did not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vbarua