Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove invalid mappings from SetOps to Calcite relations #303

Open
vbarua opened this issue Oct 4, 2024 · 0 comments
Open

remove invalid mappings from SetOps to Calcite relations #303

vbarua opened this issue Oct 4, 2024 · 0 comments

Comments

@vbarua
Copy link
Member

vbarua commented Oct 4, 2024 •
edited
Loading

In #300 we added mappings for MINUS_PRIMARY_ALL and INTERSECTION_MULTISET_ALL to the equivalent Calcite relations (Minus(all = true), Intersect(all=true)).

We did not remove the existing mappings that were used for this, MINUS_MULTISET and INTERSECTION_PRIMARY, which are technically incorrect mappings as the behaviour in the spec is not the same as what they were being mapped to in Calcite.

These mappings were kept in place temporarily to allow for users to migrate to the correct SetOps for these operations, but will be removed in a future version.
@vbarua vbarua mentioned this issue Oct 4, 2024
Merged
@vbarua vbarua changed the title remove incorrect mappings from SetOps to Calcite remove invalid mappings from SetOps to Calcite relations Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vbarua