Rewarded ads rrme #3542
Merged
Rewarded ads rrme #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkawano
requested review from
ChrisAntaki,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
oyj9109
reviewed
Aug 16, 2024
| }).start(); | ||
| } else if (this.intervention.type == InterventionType.TYPE_REWARDED_AD) { | ||
| return new AudienceActionLocalFlow(this.deps_, { | ||
| action: this.intervention.type, |
There was a problem hiding this comment.
nit: this is minor but can we keep the argument order in sync with the above?
| @@ -599,6 +611,7 @@ export class AudienceActionLocalFlow implements AudienceActionFlow { | |||
| AnalyticsEvent.ACTION_REWARDED_AD_CLOSE, | |||
| /* isFromUserAction */ true | |||
| ); | |||
| this.rewardedResult(true, false); | |||
There was a problem hiding this comment.
nit: add parameter name comments so that it's understanable without having to check the function definition.
See go/tsjs-style#comments-when-calling-a-function
“Parameter name” comments should be used whenever the method name and parameter value do not sufficiently convey the meaning of the parameter.
| @@ -558,9 +561,12 @@ export class AudienceActionLocalFlow implements AudienceActionFlow { | |||
| AnalyticsEvent.ACTION_REWARDED_AD_CLOSE_AD, | |||
| /* isFromUserAction */ true | |||
| ); | |||
| this.rewardedResult(true, false); | |||
| this.closeOptInPrompt_(); | ||
| } | ||
| } | ||
|
|
||
| private rewardedResult( |
There was a problem hiding this comment.
The function name doesn't seem to convey what exactly it does. Can you rename it to be more specific on what it does?
oyj9109
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable rewarded ads for RRME.
Demo: b/358588957