-
Notifications
You must be signed in to change notification settings - Fork 910
[WIP] Fix enthalpy related issues #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
…into fix_restart_scalars
…into fix_restart_scalars
|
@Cristopher-Morales I added the standard reference temperature to the sensible enthalpy computation everywhere. Was there a reason that sometimes Tref=298.15 and sometimes you use Tref=0? I think it should always be 298.15, so I also removed the option from the config file. |
Hi! It was added like that because it was a comment suggested by Pedro, he said that hardcoding values was not a good practice. That one should be a user defined option. Also, the enthalpy for the other models is just h=cp*T, that is the enthalpy used by a perfect gas, it is also mention in the book of blazek. I just kept the default behaviour of the other models as they were defined before. |
|
The STD_REF_TEMP=298.15 is now in option_structure.hpp, I think this is the best place for it. It is going to be very confusing when converting enthalpies with different definitions, so maybe better to keep it consistent across models and use the same constant everywhere. |
Proposed Changes
Related Work
small fixes for #2426
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.