Skip to content

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Dec 22, 2025

Proposed Changes

  • use reference temperature for enthalpy consistenly
  • Write temperature to paraview when energy=off, being consistent with other thermodynamic quantities like viscosity.
  • Fixed a bug when restarting with species.
  • When energy=off, enthalpy field will still be used to compute temperature (necessary for python wrapper)
  • Fixed an MPI bug where viscosity was out of sync when computing non-constant mass diffusivity
  • update python wrapper case. No need to put ENERGY=ON anymore. temperature field is written to paraview

Related Work

small fixes for #2426

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title fixe scalar restart, update psi case fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title fix scalar restart, update psi case Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title Fix scalar restart, update psi case [WIP] Fix scalar restart, update psi case Dec 22, 2025
bigfooted and others added 4 commits December 22, 2025 11:22
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
@bigfooted bigfooted changed the title [WIP] Fix scalar restart, update psi case Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title Fix scalar restart, update psi case [WIP] Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted marked this pull request as draft December 22, 2025 14:23
@bigfooted bigfooted changed the title [WIP] Fix scalar restart, update psi case [WIP] Fix enthalpy related issues Dec 23, 2025
@bigfooted
Copy link
Contributor Author

@Cristopher-Morales I added the standard reference temperature to the sensible enthalpy computation everywhere. Was there a reason that sometimes Tref=298.15 and sometimes you use Tref=0? I think it should always be 298.15, so I also removed the option from the config file.

@Cristopher-Morales
Copy link
Contributor

@Cristopher-Morales I added the standard reference temperature to the sensible enthalpy computation everywhere. Was there a reason that sometimes Tref=298.15 and sometimes you use Tref=0? I think it should always be 298.15, so I also removed the option from the config file.

Hi!

It was added like that because it was a comment suggested by Pedro, he said that hardcoding values was not a good practice. That one should be a user defined option. Also, the enthalpy for the other models is just h=cp*T, that is the enthalpy used by a perfect gas, it is also mention in the book of blazek. I just kept the default behaviour of the other models as they were defined before.

@bigfooted
Copy link
Contributor Author

The STD_REF_TEMP=298.15 is now in option_structure.hpp, I think this is the best place for it.

It is going to be very confusing when converting enthalpies with different definitions, so maybe better to keep it consistent across models and use the same constant everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants