[WIP] Implementing variable density for unsteady incompressible flow #2641
+159
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Cristopher-Morales can you review this pr please? |
Removed commented-out code for setting density at local point.
Updated the comment for density retrieval to reflect changes for transient density handling.
Removed unnecessary blank lines in CIncEulerVariable.hpp
Removed unnecessary blank lines in CVariable.hpp
Removed unnecessary blank lines to improve code readability.
Contributor
Hi @pcarruscag ! Yes, I can help reviewing this PR. Please let me know if you need something else from my side |
Removed commented-out code and updated density calculation.
Contributor
|
@Cristopher-Morales I guess the changes to the preconditioner can be removed from this PR since we now have your implementation |
Removed unnecessary blank lines in SetPrimVar function.
Removed unnecessary blank lines in CVariable.cpp.
Removed debug print statement from SetPrimVar function.
Comment on lines
102
to
105
|
|
||
| inline void Set_Density_time_n(unsigned long iPoint, su2double val) { | ||
| Density_time_n[iPoint] = val; | ||
| } |
Contributor
There was a problem hiding this comment.
Documentation must be added, similar to the function above SetDensity, Same for the two functions below Set_Density_unsteady and GetDensity_time_n
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
6 tasks
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements variable density treatment for unsteady incompressible flow simulations. Currently, SU2 uses constant density in transient simulations, which is inaccurate for combustion cases where density varies significantly due to heat release and species composition changes. This contribution enables proper density updates during time-stepping for flamelet-based combustion modeling. For now, only 1st order time marching is implemented
Related Work
Related to incompressible flow solver and flamelet combustion modeling. No specific issue linked yet.
PR Checklist
pre-commit run --allto format old commits.