Custom species wall BC #2618

bigfooted · 2025-11-11T21:58:18Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

implements FLUX and VALUE type wall boundary conditions for species
boundary condition can be modified using the python wrapper
default is zero flux when boundary condition is not defined

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Common/include/option_structure.inl

… in destructor Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…code/su2 into feature_custom_species_walls

Common/include/option_structure.inl

Common/src/CConfig.cpp

…type with wide type in loop condition Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…code/su2 into feature_custom_species_walls

TestCases/py_wrapper/psi_heatloss/run.py

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

TestCases/parallel_regression.py

Common/include/option_structure.hpp

Common/include/CConfig.hpp

SU2_CFD/include/drivers/CDriverBase.hpp

SU2_CFD/include/solvers/CFVMFlowSolverBase.hpp

SU2_CFD/include/solvers/CSolver.hpp

SU2_CFD/include/solvers/CSpeciesSolver.hpp

SU2_CFD/src/solvers/CSpeciesSolver.cpp

pcarruscag · 2025-12-23T22:41:43Z

SU2_CFD/src/solvers/CSpeciesSolver.cpp

+  for (auto iVar = 0u; iVar < nVar; iVar++) {
+
+       // Get wall species boundary condition type and value for this marker and species
+       su2double WallSpeciesValue = config->GetWall_SpeciesVal(Marker_Tag, iVar);
+       unsigned short wallspeciestype = config->GetWall_SpeciesType(Marker_Tag, iVar);


It would be better to fetch these values outside of the loop over vertices since they don't change for the marker

SU2_CFD/src/solvers/CSpeciesSolver.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…code/su2 into feature_custom_species_walls

bigfooted added 2 commits November 11, 2025 22:55

custom species wall BC

dc66724

default zero flux species wall BC

1d81103

bigfooted added the changelog:feature label Nov 11, 2025

bigfooted marked this pull request as draft November 11, 2025 22:10

bigfooted added the PR: draft label Nov 11, 2025

add keyword and testcase

747c7de

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

Common/include/option_structure.inl Fixed Show fixed Hide fixed

Common/include/option_structure.inl Fixed Show fixed Hide fixed

bigfooted and others added 5 commits November 12, 2025 09:29

switch to passivedouble

f1ab1a6

Potential fix for code scanning alert no. 5749: Resource not released…

d779979

… in destructor Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

typo in config_template.cfg

38d926d

Merge branch 'feature_custom_species_walls' of https://github.com/su2…

9dc1597

…code/su2 into feature_custom_species_walls

support per-species flux or value

88e2922

github-advanced-security bot found potential problems Nov 14, 2025

View reviewed changes

Common/include/option_structure.inl Fixed Show fixed Hide fixed

Common/src/CConfig.cpp Fixed Show fixed Hide fixed

bigfooted and others added 8 commits November 14, 2025 16:05

Potential fix for code scanning alert no. 5752: Comparison of narrow …

19d0bd6

…type with wide type in loop condition Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

change out-of-bounds error into warning.

062e482

Merge branch 'feature_custom_species_walls' of https://github.com/su2…

017016f

…code/su2 into feature_custom_species_walls

add testcases

5f7c4c9

Merge branch 'develop' into feature_custom_species_walls

3ece590

Merge branch 'develop' into feature_custom_species_walls

b88877b

Merge branch 'feature_custom_species_walls' of https://github.com/su2…

e3d2dc8

…code/su2 into feature_custom_species_walls

run precommit

39ad198

github-advanced-security bot found potential problems Dec 4, 2025

View reviewed changes

bigfooted and others added 5 commits December 17, 2025 10:03

Merge branch 'develop' into feature_custom_species_walls

8aebccf

Potential fix for code scanning alert no. 5867: Unused local variable

ff27515

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

cleanup

40d5b99

empty line

bbebbbb

add regression test

b916b03

bigfooted removed the PR: draft label Dec 17, 2025

bigfooted changed the title ~~[WIP] custom species wall BC~~ Custom species wall BC Dec 17, 2025

Merge branch 'develop' into feature_custom_species_walls

dc70b78

Merge branch 'develop' into feature_custom_species_walls

55179d0

bigfooted marked this pull request as ready for review December 19, 2025 07:55

bigfooted commented Dec 19, 2025

View reviewed changes

TestCases/parallel_regression.py Outdated Show resolved Hide resolved

bigfooted added 3 commits December 19, 2025 23:24

Apply suggestion from @bigfooted

776059d

update regression

d18433d

Merge branch 'develop' into feature_custom_species_walls

09ab65d

pcarruscag reviewed Dec 23, 2025

View reviewed changes

bigfooted and others added 13 commits December 24, 2025 08:06

Update Common/include/option_structure.hpp

a9bc5dc

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update Common/include/CConfig.hpp

51e84b5

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/drivers/CDriverBase.hpp

d46ac46

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CSolver.hpp

4aa5216

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CSpeciesSolver.hpp

9494da4

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/solvers/CSpeciesSolver.cpp

76c604e

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/solvers/CSpeciesSolver.cpp

f71f958

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Merge branch 'develop' into feature_custom_species_walls

d4f6e4b

Update SU2_CFD/include/solvers/CSpeciesSolver.hpp

ae62850

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/solvers/CSpeciesSolver.hpp

9749e64

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

implement review changes

72eb31e

Merge branch 'feature_custom_species_walls' of https://github.com/su2…

dff9fbe

…code/su2 into feature_custom_species_walls

implement review changes

3357529

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Custom species wall BC #2618

Custom species wall BC #2618

bigfooted commented Nov 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag Dec 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Custom species wall BC #2618

Are you sure you want to change the base?

Custom species wall BC #2618

Conversation

bigfooted commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bigfooted commented Nov 11, 2025 •

edited

Loading