Feature new flamelet #2057
Feature new flamelet #2057
Conversation
…nd generalized the flamelet output options accordingly
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /*--- The controlling variables are progress variable and total enthalpy ---*/ | ||
| n_control_vars = 2; | ||
| /*--- The controlling variables are progress variable, total enthalpy, and optionally mixture fraction ---*/ | ||
| //n_control_vars = nSpecies - n_user_scalars; |
Check notice
Code scanning / CodeQL
Commented-out code
|
@EvertBunschoten That's great, thanks! Can you first make sure that the regression tests run again? Now, all existing flamelet regression tests fail. |
…of CDataDrivenFluid
The regression tests for flamelet now complete nominally again |
|
Help me out with this PR #2077 |
…in flamelet fluid model
TestCases/flamelet/05_laminar_premixed_ch4_flame_cfd_axi/lam_prem_ch4_cfd_axi.cfg
Show resolved
Hide resolved
…into feature_new_flamelet
|
@EvertBunschoten there was a bug that I noticed this week. When we get the enclosing triangle of the lookup point, we sometimes fail to get a proper intersection using set_intersection. We can then take one of the adjacent triangles instead. I only noticed it for one very specific lookup table and setup, so it is a pretty rare occurrence. |
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Looks good, minor comments below + Wally's about consistency of variable names if possible.
…into feature_new_flamelet
|
I implemented most of the reviewers suggestions. The only suggestion I left unchanged is the upper-case consistency issue raised by Wally. Since it is an optional output and it depends on the controlling variable names the user provides, I think it would be more intuitive to keep the font case consistent between the names under |
|
I'm fine with the consistency with the user input. Is the dry run mode working ok for these variables? |
Yes. Both for direct and adjoint the RMS, BGS, and MAX of the controlling variables show up in dry run mode as they're listed in the configuration file. |
…ue to update of the solution file in test cases repository
Proposed Changes
Introduction of mixture fraction transport equation to flamelet species solver. This allows for solving partially premixed, laminar combustion problems with heat transfer. The controlling variable names are generalized and have to be specified in the configuration file, such that they can be matched to the controlling variable names in the table.
Additionally, the output writing for the flamelet variables has been generalized such that it can generate all the necessary outputs for any number of controlling variables.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.