Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support building on native Windows #11

Closed
akshatmittal opened this issue Dec 29, 2020 · 3 comments
Closed

Feature: Support building on native Windows #11

akshatmittal opened this issue Dec 29, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@akshatmittal
Copy link
Contributor

This will fail to run on Windows because it uses path.normalize for URL pathnames.

The behavior is very different on Windows and *nix systems and is only recommended for literal file paths and not URL parsing. https://nodejs.org/api/path.html#path_path_normalize_path

Alternative: URL class in JS.

@styxlab
Copy link
Owner

styxlab commented Dec 29, 2020

Currently this repository only supports *nix and the Windows Subsystem for Linux (WSL), but not native Windows. I am open to PRs that make it work for native Windows, too. Before making any changes, please read the previous discussions on this topic: #4 and #7.

@akshatmittal
Copy link
Contributor Author

Thanks for pointing me to those discussions, I didn't see them before. At the moment, path normalize is the only thing I see to support Windows. I will have a look at other parts sometime to see if there's anything else that might need changes.

I might PR this change anyway with a solution that works for both *nix and Windows, and not a Windows specific change.

@styxlab styxlab changed the title Fails to work on Windows Feature: Support building on native Windows Dec 29, 2020
@styxlab styxlab added the enhancement New feature or request label Dec 29, 2020
@styxlab
Copy link
Owner

styxlab commented Jan 25, 2021

I removed the path.normalize dependency, so this does not inhibit native Windows builds anymore. I am closing this issue, but feel free to open a new one, if this does not fully solve the original issue.

@styxlab styxlab closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants