You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently this repository only supports *nix and the Windows Subsystem for Linux (WSL), but not native Windows. I am open to PRs that make it work for native Windows, too. Before making any changes, please read the previous discussions on this topic: #4 and #7.
Thanks for pointing me to those discussions, I didn't see them before. At the moment, path normalize is the only thing I see to support Windows. I will have a look at other parts sometime to see if there's anything else that might need changes.
I might PR this change anyway with a solution that works for both *nix and Windows, and not a Windows specific change.
styxlab
changed the title
Fails to work on Windows
Feature: Support building on native Windows
Dec 29, 2020
I removed the path.normalize dependency, so this does not inhibit native Windows builds anymore. I am closing this issue, but feel free to open a new one, if this does not fully solve the original issue.
This will fail to run on Windows because it uses
path.normalize
for URL pathnames.The behavior is very different on Windows and *nix systems and is only recommended for literal file paths and not URL parsing. https://nodejs.org/api/path.html#path_path_normalize_path
Alternative:
URL
class in JS.The text was updated successfully, but these errors were encountered: