updates

Author: studerw

README.md

@@ -1,40 +1,40 @@
-# long-polling-redis
-Example App showing client side long polling using Spring MVC and Redis Pub/Sub.
-
-Uses Spring 3 MVC, Spring Data Redis, JQuery on the front-end, and an embedded Redis Server.
-
-### Overview
-
-A naive approach to front-end querying of the backend for new emails, messages, alerts, etc. is to poll every *x* seconds.
-In Javascript, this is usually done using the `setInterval()` function.
-
-For example, if one were to design a email app similar to GMail, the user will expect new incoming
-messages to be shown in the inbox count automatically (i.e. without having to constantly refresh the page).
-
-Polling again and again is a waste of resources on both the client and server, especially when the frequency
-of polling is far greater than new incoming messages are received. 
-
-A better way to approach the problem is by using async requests on a pubsub channel on the backend, along
-with a recursive function on the front-end that only makes new requests when the old has actually returned.
-
-
-### Instructions
-
-From the command line, run:
-
-````
-$ mvn tomcat7:run
-````
-
-Open your browser to [http://127.0.0.1:8080](http://127.0.0.1:8080).
-
-In the input box, add messages.
-
-The left column shows the output from a front-end approach using async requests on the server and a recursive
-function on the front-end to re-call itself upon completion / timeout of each request. Requests on the back-end
-will simply block (though without holding the request thread) until Redis informs the waiting requests that a new message
-has been added.
-
-The right column shows the traditional attempt with polling. Every 10 seconds (configurable in `app.properties` file),
-the front-end will make a call to the server requesting new messages. The server responds immediately with the result.
-If messages are created less frequently than the poll time, most of the requests are wasted.
+# long-polling-redis
+Example App showing client side long polling using Spring MVC and Redis Pub/Sub.
+
+Uses Spring 3 MVC, Spring Data Redis, JQuery on the front-end, and an embedded Redis Server.
+
+### Overview
+
+A naive approach to front-end querying of the backend for new emails, messages, alerts, etc. is to poll every *x* seconds.
+In Javascript, this is usually done using the `setInterval()` function.
+
+For example, if one were to design a email app similar to GMail, the user will expect new incoming
+messages to be shown in the inbox count automatically (i.e. without having to constantly refresh the page).
+
+Polling again and again is a waste of resources on both the client and server, especially when the frequency
+of polling is far greater than new incoming messages are received. 
+
+A better way to approach the problem is by using async requests on a pubsub channel on the backend, along
+with a recursive function on the front-end that only makes new requests when the old has actually returned.
+
+
+### Instructions
+
+From the command line, run:
+
+````
+$ mvn tomcat7:run
+````
+
+Open your browser to [http://127.0.0.1:8080](http://127.0.0.1:8080).
+
+In the input box, add messages.
+
+The left column shows the output from a front-end approach using async requests on the server and a recursive
+function on the front-end to re-call itself upon completion / timeout of each request. Requests on the back-end
+will simply block (though without holding the request thread) until Redis informs the waiting requests that a new message
+has been added.
+
+The right column shows the traditional attempt with polling. Every 10 seconds (configurable in `app.properties` file),
+the front-end will make a call to the server requesting new messages. The server responds immediately with the result.
+If messages are created less frequently than the poll time, most of the requests are wasted.

src/main/java/com/studerw/appMsg/AppMsg.java

@@ -3,7 +3,6 @@
 import org.apache.commons.lang3.builder.ToStringBuilder;
 
 import java.io.Serializable;
-import java.util.Comparator;
 
 /**
  * @author William Studer

src/main/java/com/studerw/appMsg/MemoryAppMsgRepo.java

@@ -5,7 +5,6 @@
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
-import org.springframework.data.redis.core.RedisTemplate;
 import org.springframework.data.redis.core.StringRedisTemplate;
 import org.springframework.stereotype.Component;
 

src/main/java/com/studerw/config/ApplicationConfig.java

@@ -1,6 +1,5 @@
 package com.studerw.config;
 
-import com.studerw.appMsg.AppMsg;
 import com.studerw.appMsg.AppMsgHandler;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -13,18 +12,14 @@
 import org.springframework.core.env.Environment;
 import org.springframework.data.redis.connection.RedisConnectionFactory;
 import org.springframework.data.redis.connection.jedis.JedisConnectionFactory;
-import org.springframework.data.redis.core.RedisTemplate;
 import org.springframework.data.redis.core.StringRedisTemplate;
 import org.springframework.data.redis.listener.PatternTopic;
 import org.springframework.data.redis.listener.RedisMessageListenerContainer;
 import org.springframework.data.redis.listener.adapter.MessageListenerAdapter;
 import org.springframework.stereotype.Controller;
-import org.springframework.web.context.request.async.DeferredResult;
 import redis.embedded.RedisServer;
 
 import java.io.IOException;
-import java.util.List;
-import java.util.concurrent.ConcurrentHashMap;
 
 import static org.springframework.context.annotation.ComponentScan.Filter;
 

src/main/java/com/studerw/config/WebAppInitializer.java

@@ -1,10 +1,10 @@
 package com.studerw.config;
 
 import org.springframework.web.filter.CharacterEncodingFilter;
-import org.springframework.web.filter.DelegatingFilterProxy;
 import org.springframework.web.servlet.support.AbstractAnnotationConfigDispatcherServletInitializer;
 
-import javax.servlet.*;
+import javax.servlet.Filter;
+import javax.servlet.ServletRegistration;
 
 public class WebAppInitializer extends AbstractAnnotationConfigDispatcherServletInitializer {
 

src/main/java/com/studerw/error/CustomErrorController.java

@@ -1,16 +1,14 @@
 package com.studerw.error;
 
-import java.text.MessageFormat;
-
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
+import com.google.common.base.Throwables;
 import org.springframework.http.HttpStatus;
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
 import org.springframework.web.bind.annotation.RequestMapping;
 
-import com.google.common.base.Throwables;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.text.MessageFormat;
 
 @Controller
 class CustomErrorController {

src/main/java/com/studerw/error/ExceptionHandler.java

@@ -1,11 +1,10 @@
 package com.studerw.error;
 
+import com.google.common.base.Throwables;
 import org.springframework.web.bind.annotation.ControllerAdvice;
 import org.springframework.web.context.request.WebRequest;
 import org.springframework.web.servlet.ModelAndView;
 
-import com.google.common.base.Throwables;
-
 /**
  * General error handler for the application.
  */
@@ -22,4 +21,4 @@ public ModelAndView exception(Exception exception, WebRequest request) {
 		modelAndView.addObject("errorMessage", Throwables.getRootCause(exception));
 		return modelAndView;
 	}
-}
+}

src/main/java/com/studerw/support/web/FlashMessageHelper.java

@@ -1,10 +1,10 @@
 package com.studerw.support.web;
 
-import static com.studerw.support.web.FlashMessage.MESSAGE_ATTRIBUTE;
-
 import org.springframework.ui.Model;
 import org.springframework.web.servlet.mvc.support.RedirectAttributes;
 
+import static com.studerw.support.web.FlashMessage.MESSAGE_ATTRIBUTE;
+
 public final class FlashMessageHelper {
 
     private FlashMessageHelper() {

src/main/resources/logback.xml

@@ -17,5 +17,5 @@
 
 	<logger name="com.github.kstyrc" level="DEBUG" />
 	<logger name="org.springframework" level="WARN" />
-	<logger name="com.studerw" level="INFO" />
+	<logger name="com.studerw" level="DEBUG" />
 </configuration>

src/main/webapp/WEB-INF/i18n/messages.properties

@@ -1,6 +1,6 @@
-view.index.title=Home page
-signup.success=Congratulations {0}! You have successfully signed up.
-
-# Validation messages
-notBlank.message = The value may not be empty!
+view.index.title=Home page
+signup.success=Congratulations {0}! You have successfully signed up.
+
+# Validation messages
+notBlank.message = The value may not be empty!
 email.message = The value must be a valid email!